Moved templates from old folder location to new #6073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
The changes LGTM but I wonder if we should divide this into two PRs to avoid breakage during deploy. I've had that happened to me when renaming an included file, don't know if this would be the case for dotcom, you may get alerts even if for just a few minutes.
pbking
added a commit
that referenced
this pull request
Jul 20, 2022
Refactor/blockbase color admin (#6043) Moved templates from old folder location to new (#6073) Blockbase: Implement the Button elements API (#6041) Blockbase: Implement Comment Block and removed CSS (#6080) Fix/migrate blockbase font self hosted (#6123) Blockbase children: update comments block (#6153) Blockbase: Changed the trigger to render social icons (#6079) Blockbase: move button padding styles from ponyfill to theme.json (#5901) Co-authored-by: Grant Kinney <[email protected]> Co-authored-by: Jeremy Yip <[email protected]> Co-authored-by: MaggieCabrera <[email protected]> Co-authored-by: madhusudhand <[email protected]>
Merged
|
Closing: Work merged in #6167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the templates (and template parts) folder location from the old location to the new. It also updates the "pattern registration" that registers Blockbase's template parts as patterns.
Intended for Blockbase 3