#5894: Blockbase: Fix comment subscription checkboxes #6140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhusudhand
requested changes
Jun 28, 2022
|
I think I'd rather go with #6109 as a solution instead, since it removes all the extra CSS from Blockbase and relies on the site editor instead. |
|
I agree it seems like #6109 is a better way to go. |
|
Closing, as the alternative PR (#6109) was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Adjust the grid for post comments on Blockbase to fix overlap issue that happens on Blockbase and children. I tested change on Blockbase, Dorna, and Winkel.
Before
After
Related issue(s):
Fixes #5894