Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archeo: fix footer spacing at mobile #5640

Merged
merged 3 commits into from
Mar 11, 2022
Merged

Archeo: fix footer spacing at mobile #5640

merged 3 commits into from
Mar 11, 2022

Conversation

mikachan
Copy link
Member

@mikachan mikachan commented Mar 8, 2022

Changes proposed in this Pull Request:

This tidies up the footer spacing and alignment, following the suggestions from #5631.

Before After
image image

Related issue(s):

#5631

@mikachan mikachan added the [Theme] Archeo Automatically generated label for Archeo. label Mar 8, 2022
@mikachan mikachan requested review from kjellr and a team March 8, 2022 21:34
@mikachan mikachan self-assigned this Mar 8, 2022
@mikachan mikachan mentioned this pull request Mar 8, 2022
Closed
4 tasks
@kjellr
Copy link
Contributor

kjellr commented Mar 9, 2022

This looks pretty good! While we're adjusting this: The fixed 50px blockGap for the navigation items feels a little too wide on small screens.

Can we change that to var(--wp--custom--spacing--small) in both he header and footer? That way it will be tied into one of our more standardized units too.

@mikachan
Copy link
Member Author

mikachan commented Mar 9, 2022

Thanks @kjellr! I've changed the blockGap in the header and footer to var(--wp--custom--spacing--small). It does look better on small screens 👍

@mikachan mikachan mentioned this pull request Mar 9, 2022
Merged
@mikachan mikachan added this to the Archeo milestone Mar 9, 2022
pbking
pbking approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@pbking pbking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikachan mikachan mentioned this pull request Mar 10, 2022
Closed
@jffng jffng force-pushed the archeo/footer-spacing branch from 39d6205 to 5e645d0 Compare March 11, 2022 20:40
@jffng jffng merged commit b4ade01 into trunk Mar 11, 2022
@jffng jffng deleted the archeo/footer-spacing branch March 11, 2022 20:40
@mikachan mikachan mentioned this pull request Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbking pbking pbking approved these changes

@kjellr kjellr Awaiting requested review from kjellr

Assignees

@mikachan mikachan

Labels
[Theme] Archeo Automatically generated label for Archeo.
Projects
None yet
Milestone
Archeo
Development

Successfully merging this pull request may close these issues.
4 participants
@mikachan @kjellr @pbking @jffng