Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archeo: Navigation block blockgap not working #5632

Closed
MaggieCabrera opened this issue Mar 8, 2022 · 4 comments
Closed

Archeo: Navigation block blockgap not working #5632

MaggieCabrera opened this issue Mar 8, 2022 · 4 comments
Labels
[Theme] Archeo Automatically generated label for Archeo.
Milestone
Archeo

Comments

@MaggieCabrera
Copy link
Contributor

While working on remote I was going over the Archeo block navigation markup and I think that it is wrong and it's not being applied.
@MaggieCabrera MaggieCabrera added the [Theme] Archeo Automatically generated label for Archeo. label Mar 8, 2022
@mikachan mikachan added this to the Archeo milestone Mar 9, 2022
@mikachan
Copy link
Member

I think blockGap is being applied correctly, although the value is about to be changed in this PR: #5640

Was it just blockGap that didn't seem to be working, or was there anything else?

@MaggieCabrera
Copy link
Contributor Author

just blockgap, I changed the value while pairing with Matias and nothing seemed to be happening

@mikachan
Copy link
Member

Oh! It seems to be working now, or at least it is for me 😅

@pbking
Copy link
Contributor

pbking commented Mar 10, 2022

Blockgap is working as expected for me. Adjusting the blockGap value on navigation block in the header.html template part changes the rendering of the desktop menu items.

Closing. Please reopen if this persists after #5640 lands.

@pbking pbking closed this as completed Mar 10, 2022
@mikachan mikachan mentioned this issue Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Theme] Archeo Automatically generated label for Archeo.
Projects
None yet
Milestone
Archeo
Development

No branches or pull requests
3 participants
@pbking @mikachan @MaggieCabrera