Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End of Year: epilogue story design #467

Merged
merged 7 commits into from
Oct 31, 2022
Merged

End of Year: epilogue story design #467

merged 7 commits into from
Oct 31, 2022

Conversation

leandroalonso
Copy link
Member

📘 Project: #376

Add the design for the epilogue story.

iPhone 8 iPhone 14 iPhone 14 Pro Max
Simulator Screen Shot - iPhone 8 - 2022-10-27 at 09 40 41 Simulator Screen Shot - iPhone 14 - 2022-10-27 at 09 40 48 Simulator Screen Shot - iPhone 14 Pro Max - 2022-10-27 at 09 40 55

To test

I recommend using these devices to test, given they provide different screen sizes:

  • iPhone 8
  • iPhone 14
  • iPhone 14 Pro Max
  1. Enable the endOfYear flag in FeatureFlag.swift
  2. Run the app and make sure you're logged in to an account with a few items on Listening History
  3. When the prompt appears, tap "View My 2022"
  4. Navigate to the last story
  5. ✅ Check the design
  6. Tap "Replay"
  7. ✅ Stories should replay

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@leandroalonso leandroalonso added the [Project] End of Year 2023 End of Year project label Oct 31, 2022
@leandroalonso leandroalonso added this to the Future milestone Oct 31, 2022
@leandroalonso leandroalonso requested a review from a team as a code owner October 31, 2022 19:09
emilylaguna
emilylaguna approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@emilylaguna emilylaguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, left one nitpick comment.

podcasts/End of Year/Stories/DynamicBackgroundView.swift Outdated Show resolved Hide resolved
Base automatically changed from task/376-longest-episode-story-design to trunk October 31, 2022 21:11
@leandroalonso @emilylaguna
Remove breakline
1ede5a3 
Co-authored-by: Emily Laguna <[email protected]>
@leandroalonso leandroalonso merged commit 52ff67b into trunk Oct 31, 2022
@leandroalonso leandroalonso deleted the task/376-epilogue-story-design branch October 31, 2022 21:29
@leandroalonso leandroalonso mentioned this pull request Oct 31, 2022
Closed
36 tasks
@ashiagr ashiagr mentioned this pull request Nov 14, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilylaguna emilylaguna emilylaguna approved these changes

Assignees
No one assigned
Labels
[Project] End of Year 2023 End of Year project
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.
2 participants
@leandroalonso @emilylaguna