-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End of Year: Epilogue story design #567
Conversation
…tomattic/pocket-casts-android into task/410-epilogue-story-design
Timer should not be running before it is started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
The only issue I noticed was that, with the pausing behavior, if your finger moves at all, the story continues playing. Seems like it would be nice for the pause to persist as long as the finger is held down particularly since I found it easy to accidentally move my finger just a bit when I was trying to pause.
Merging this PR, tried to fix it in #581. |
iOS PR: Automattic/pocket-casts-ios#467
Description
Testing Instructions
END_OF_YEAR_ENABLED
feature flag totrue
in base.gradleScreenshots or Screencast
P.S. I picked the background color from the iOS app and applied the existing gradient on other screens.
Checklist
modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...