Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End of Year: show longest episode played #416

Merged
merged 12 commits into from
Oct 20, 2022
Merged

End of Year: show longest episode played #416

merged 12 commits into from
Oct 20, 2022

Conversation

leandroalonso
Copy link
Member

📘 Project: #376

Show the longest episode played story.

To test

  1. Enable the endOfYear flag in FeatureFlag.swift
  2. Run the app and make sure you're logged in to an account with a few items on Listening History
  3. When the prompt appears, tap "View My 2022"
  4. Skip to the latest story (the 7th)
  5. ✅ Check that the longest episode that was played is shown, alongside its duration and podcast thumb

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@leandroalonso leandroalonso added the [Project] End of Year 2023 End of Year project label Oct 19, 2022
@leandroalonso leandroalonso requested a review from a team as a code owner October 19, 2022 21:01
@leandroalonso leandroalonso mentioned this pull request Oct 19, 2022
Closed
36 tasks
@leandroalonso leandroalonso mentioned this pull request Oct 20, 2022
Merged
3 tasks
emilylaguna
emilylaguna approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@emilylaguna emilylaguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

podcasts/End of Year/Stories/LongestEpisodeStory.swift Outdated Show resolved Hide resolved
@leandroalonso
Copy link
Member Author

@emilylaguna I addressed this here: 5612d7a

Base automatically changed from task/376-show-top-podcasts to trunk October 20, 2022 19:42
@leandroalonso leandroalonso merged commit c3f3ad3 into trunk Oct 20, 2022
@leandroalonso leandroalonso deleted the task/376-show-longest-episode branch October 20, 2022 20:07
@ashiagr ashiagr mentioned this pull request Nov 4, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilylaguna emilylaguna emilylaguna approved these changes

Assignees
No one assigned
Labels
[Project] End of Year 2023 End of Year project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leandroalonso @emilylaguna