Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End of Year: show number of listened podcasts and episodes #414

Merged
merged 4 commits into from
Oct 20, 2022
Merged

End of Year: show number of listened podcasts and episodes #414

merged 4 commits into from
Oct 20, 2022

Conversation

leandroalonso
Copy link
Member

📘 Project: #376

Adds a story that shows the number of listened podcasts and episodes. Designs are not contemplated in this task.

To test

  1. Enable the endOfYear flag in FeatureFlag.swift
  2. Run the app and make sure you're logged in to an account with a few items on Listening History
  3. When the prompt appears, tap "View My 2022"
  4. Skip to the fourth story
  5. ✅ Check that the number of played podcasts and episodes is shown

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@leandroalonso leandroalonso added the [Project] End of Year 2023 End of Year project label Oct 19, 2022
@leandroalonso leandroalonso requested a review from a team as a code owner October 19, 2022 19:18
@leandroalonso leandroalonso mentioned this pull request Oct 19, 2022
Closed
36 tasks
@emilylaguna emilylaguna self-assigned this Oct 20, 2022
Base automatically changed from task/376-show-different-categories-listened to trunk October 20, 2022 17:15
emilylaguna
emilylaguna suggested changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@emilylaguna emilylaguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stats look good, I left a comment about reusing the date range SQL fragment.

Let me know what you think.

Modules/DataModel/Sources/PocketCastsDataModel/Private/Managers/EndOfYearDataManager.swift
Comment on lines +78 to +79
lastPlaybackInteractionDate IS NOT NULL AND
lastPlaybackInteractionDate BETWEEN strftime('%s', date('now','start of year')) and strftime('%s', 'now')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this bit of SQL is being used in every query. I wonder if can extract this out so it can be reused instead of C&P it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind if I change that on #416? Just to avoid a bunch of merges/rebases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. :shipit:

@leandroalonso leandroalonso merged commit 4a3c308 into trunk Oct 20, 2022
@leandroalonso leandroalonso deleted the task/376-show-number-of-podcasts-and-number-of-episodes-played branch October 20, 2022 17:42
@leandroalonso leandroalonso mentioned this pull request Oct 20, 2022
Merged
3 tasks
@ashiagr ashiagr mentioned this pull request Nov 3, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilylaguna emilylaguna emilylaguna approved these changes

Assignees

@leandroalonso leandroalonso

Labels
[Project] End of Year 2023 End of Year project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leandroalonso @emilylaguna