Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update up-next icon to be 24dp #936

Merged
merged 1 commit into from
May 8, 2023
Merged

Conversation

mchowning
Copy link
Contributor

Description

When I updated the up next icon to be more centered, the svg's width and height were reduced, and I didn't realize this would reduce the icon's size on the podcast settings screen. This increases the size of the new icon to be the same as the old icon.

Reported by a beta user https://pocketcastsbeta.slack.com/archives/C013F9RM6UA/p1683238245603559

Warning
Because this is a regression from 7.37, I'm targeting the release/7.38 branch. I don't think we need to release a new beta with this though, and it can just go out with the next beta or the actual prod release.

Testing Instructions

1. Phone

  1. Install the phone app
  2. Go to a subscribed podcast
  3. Tap on the ⚙️ to open the podcasts settings
  4. ✅ Verify that the icon by the "Add to Up Next" setting is the proper size

2. Watch

  1. Install the watch app
  2. Make sure you have one episode that is both in the up next queue and downloaded
  3. Go to the Downloads screen
  4. ✅ Verfiy that the up next icon is applied to that episode's chip and looks correct

Screenshots or Screencast

Phone Watch
image image

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

@mchowning mchowning requested a review from a team as a code owner May 5, 2023 14:52
@ashiagr ashiagr merged commit 349319b into release/7.38 May 8, 2023
@ashiagr ashiagr deleted the fix/up-next-icon-size branch May 8, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants