Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add up next icon to episode chip #914

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Conversation

mchowning
Copy link
Contributor

Description

This adds an up-next icon to the EpisodeChip.

In addition, this updates the episode chip to vertically center the podcast image when there are no icons present. Unfortunately, you can't test this currently because the only screens using this chip right now are the Up Next screen and the Downloads screen and I certainly hope that any podcast on one of those screens should either be in the Up Next or downloaded. 😄 I've included a screenshot below though so you can see what it would look like.

Note
This PR builds on #909.

Testing Instructions

  1. Go to the Up Next queue or the Downloads page
  2. Observe that the up-next icon and download icons are presented when appropriate

Screenshots or Screencast

Both icons Up Next only Downloaded only No icons
image image image image

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

@mchowning mchowning requested a review from a team as a code owner April 26, 2023 20:50
@ashiagr
Copy link
Contributor

ashiagr commented Apr 27, 2023

Looks good, just that up-next icon appears a little bit higher

App

Figma

Screenshot 2023-04-27 at 1 22 31 PM

@mchowning mchowning added the [Area] Wear OS watch app label Apr 27, 2023
@mchowning mchowning force-pushed the update/episode-chip-up-next-icon branch from 0c140bb to a894914 Compare April 27, 2023 11:19
@mchowning
Copy link
Contributor Author

mchowning commented Apr 27, 2023

up-next icon appears a little bit higher

Thanks for calling that out. I'm not sure why the up next icon in the project isn't centered vertically, so I updated it from FIgma. The new icon uses a slightly thicker strokes and generally has a slightly different style, so I also updated the download icon so they both have the same style (a894914). This change also updates the icons in the phone app.

Before Now
image image

Base automatically changed from update/watch-up-next-ui to main April 27, 2023 11:36
@mchowning mchowning merged commit 42ea566 into main Apr 27, 2023
@mchowning mchowning deleted the update/episode-chip-up-next-icon branch April 27, 2023 11:52
@mchowning mchowning mentioned this pull request May 5, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants