Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Automotive search #681

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Conversation

geekygecko
Copy link
Member

@geekygecko geekygecko commented Jan 9, 2023

Description

This change improves the Automotive search. One of our partners has reported search issues. The previous search was based on our voice search which I don't believe works well in this use case.

Fixes #663
Fixes #664

Testing Instructions

  1. Deploy the Automotive module to an Automotive emulator
  2. Tap the search icon (next to the settings cog)
  3. Search for 'Tech News'
  4. Scroll down to 'Daily Tech News Show'
  5. Tap the row
  6. Tap the first episode
  7. Pause the episode, close the player, tap the back button twice
  8. ✅ Verify on the 'Podcasts' tab that the podcast 'Daily Tech News Show' is listed (on Automotive by default, you are subscribed to podcasts)
  9. Tap the search icon again
  10. Clear the search text
  11. Search for 'Tech News'
  12. ✅ Verify the top result is now 'Daily Tech News Show' (your subscribed to podcasts should appear first)
  13. Clear the search
  14. Tap on the wifi icon in the status bar
  15. Turn off mobile and wifi data
  16. Search for 'Material'
  17. ✅ Verify the error message 'Something went wrong' is displayed. (Unfortunately I couldn't find a way to add a custom error message)

Screenshot

Screenshot_20230109_200641

Screenshot_20230109_200155

@geekygecko geekygecko marked this pull request as ready for review January 9, 2023 10:29
@geekygecko geekygecko requested a review from a team as a code owner January 9, 2023 10:29
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described! Thank you for these improvements, @geekygecko

@ashiagr ashiagr merged commit 05cfdc7 into main Jan 9, 2023
@ashiagr ashiagr deleted the update/automotive-podcast-search branch January 9, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants