Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Automotive: improve the search feature #664

Closed
1 task done
geekygecko opened this issue Dec 16, 2022 · 0 comments · Fixed by #681
Closed
1 task done

Android Automotive: improve the search feature #664

geekygecko opened this issue Dec 16, 2022 · 0 comments · Fixed by #681
Assignees
Labels
[Type] Bug Not functioning as intended.

Comments

@geekygecko
Copy link
Member

geekygecko commented Dec 16, 2022

Description

When using Automotive search, it gives unpredictable results. If you search for the 'The Daily' it will initially search and return podcasts, later searches will return episodes from the podcast. The issue is that the search is using the play from search method, which is meant to be used for using voice to start playing an episode.

Instead this method should return a list of podcasts from your collection and the server.

This is the current search method used in Automotive. https://github.com/Automattic/pocket-casts-android/blob/main/modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/playback/PlaybackService.kt#L569

For reference here is the voice search https://github.com/Automattic/pocket-casts-android/blob/main/modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/playback/MediaSessionManager.kt#L666

Step-by-step reproduction instructions

  1. Open the Automotive app
  2. Tap the search icon
  3. Type in 'The Daily'
  4. ✅ Verify multiple podcasts are shown such as 'The Daily' and 'The Daily Stoic'
  5. Tap 'The Daily Stoic'
  6. Tap the back arrow to return to the app
  7. Tap the search icon again
  8. Type in 'The Daily'

Notice that only episodes from 'The Daily Stoic' are shown and no podcasts are in the results.

Screenshots or screen recording

No response

Did you search for existing bug reports?

  • I have searched for existing bug reports.

Device, Operating system, and Pocket Casts app version

No response

@geekygecko geekygecko added the [Type] Bug Not functioning as intended. label Dec 16, 2022
@geekygecko geekygecko self-assigned this Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Not functioning as intended.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant