Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable scale to replay button #624

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Dec 1, 2022

Description

Disables scaling to large font sizes on the replay button so that it is consistent with the rest of the story view. Follow-up on changes in #619. If this was intended behavior, please just close this PR. I just figured it would be quicker to put up a PR in case we do want that change. cc: @adamzelinski

Note
This PR is targeting release/7.21.1, but I also think it would be fine to delay this to the next release since this is a minor issue.

Testing Instructions

  1. Set device font size to a large setting
  2. View EOY epilogue Story
  3. ✅ Observer that the replay button has a consistent size with the rest of the text

Screenshots or Screencast

Before After
image image

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@mchowning mchowning requested a review from a team as a code owner December 1, 2022 14:31
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

@ashiagr ashiagr merged commit 10cb055 into release/7.27.1 Dec 1, 2022
@ashiagr ashiagr deleted the fix/disable-scale-on-replay-button branch December 1, 2022 15:02
@ashiagr ashiagr added this to the 7.27 milestone Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants