End of Year: Design tweaks (part ii) #619
Conversation
(cherry picked from commit 4fa2583)
ashiagr
force-pushed
the
task/410-design-tweaks-partii
branch
from
d32332e to
e4fb26e
Compare
There was a problem hiding this comment.
I'll let @adamzelinski take a look at this from a UI perspective, but the code looks good.
The only thing I noticed that seemed off was that on the two screens where we removed the Share button, the content does not expand to take up the Share Button space. This is visible with a normal font size (because the content does not have a black background like the space where the share button does), but it is much more obvious when a larger font size is used where the user can scroll.
device-2022-11-30-131316.mp4
Also seems like the spacing gets rather crowded with the larger font size.
| @@ -52,7 +59,7 @@ fun StoryEpilogueView( | |||
|
|
|||
| Spacer(modifier = modifier.weight(1f)) | |||
|
|
|||
| HeartImage() | |||
| PulsatingHeart() | |||
There was a problem hiding this comment.
The only thing I think it needs matt is the last story if you try to skip the story it just loops back onto the last story, it should close the story 🤔 😉
(other then a story top 15-25 podcasts the current story should say add the time for the each of the top 5😉, theirs allways next year tho),
(last story should also collect all the story's and allows sharing of the 9 as a group as thats better for social engagement )
There was a problem hiding this comment.
Your feedback is valuable, @CookieyedCodes! Thanks for sharing it. 🙏 I'll add it to the backlog.
|
Thanks for these updates @ashiagr it's looking great and I love the new heart animation! As for the text size on the screenshot, yes it looks funny if it scrolls. On iOS, we're using dynamic type but there is also a max size set so maybe we could look at doing something similar? Also, in iOS on the first and last screen now that the share button is hidden we have expanded those stories |
|
Thank you, for the feedback!
To match iOS, expanded those screens on Android. - eff6611
To improve experience, disabled text scaling if the device font scale is beyond 1.15 (popular values: 1.0, 1.15, 1.3) - 1e2ed1f Available font scales from Tracks:
max_font_size.mp4Feedback from Slack DM
I'll address any feedback in a future PR. |
| ) { | ||
| Text( | ||
| text = text, | ||
| color = color, | ||
| fontSize = 22.sp, | ||
| lineHeight = 30.sp, | ||
| fontSize = if (disableScale) fontSize.value.nonScaledSp else fontSize, |
There was a problem hiding this comment.
One minor issue that I think this logic creates is that someone with a font scaled to 1.1 will have a bigger font than someone whose font is set to be 1.2 because the 1.2 gets reset to 1.0. Very minor issue, but I wanted to mention it.
Description
Applies small design tweaks:
Intro Screen
Generic
ListenedCategories,LongestEpisode,TopPodcastandListenedNumbersstoriesTop Categories
Epilogue
I also captured an
UnknownFormatConversionExceptionin 7.27 in e4fb26e. It is for the Arabic Letter Meem (م). The letter is used inside values-ar/strings.xml in several places. I'll get that fixed in a separate PR after consulting someone from the i18n team.