Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of Year: Hide share from first and last story #609

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Nov 24, 2022

📘 Project: #410

Description

This hides the share button from the first and last story.

Testing Instructions

  1. Run the app and make sure you're logged in to an account with a few items on Listening History
  2. Go to Profile tab and tap "Your Year in Podcasts"
  3. Notice that first and last stories do not show the share button.

P.S. I also added tracking (🔵 Tracked: end_of_year_story_retry_button_tapped) for retry button
which was added in this PR.

Screenshots or Screencast

share.mp4

@ashiagr ashiagr requested a review from a team as a code owner November 24, 2022 05:04
@ashiagr ashiagr enabled auto-merge November 24, 2022 06:50
@ashiagr ashiagr merged commit db6d0bd into main Nov 24, 2022
@ashiagr ashiagr deleted the task/410-remove-share-first-last-story branch November 24, 2022 07:07
@ashiagr ashiagr added this to the 7.27 ❄️ milestone Nov 24, 2022
ashiagr added a commit that referenced this pull request Nov 24, 2022
…ast-story

End of Year: Hide share from first and last story
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants