Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End of Year: Add retry action #597

Merged
merged 1 commit into from
Nov 21, 2022
Merged

End of Year: Add retry action #597

merged 1 commit into from
Nov 21, 2022

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Nov 21, 2022

📘 Project: #410

Description

Adds retry button on error.

Testing Instructions

  1. Set END_OF_YEAR_ENABLED feature flag to true in base.gradle
  2. Fresh install the app
  3. Login to your sync account
  4. Re-run the app
  5. Enable airplane mode
  6. Tap "View my 2022"
  7. Notice error screen is displayed with retry button
  8. Disable airplane mode
  9. Tap retry button
  10. Notice that stories are loaded.

Screenshots or Screencast

retry.mp4

@ashiagr ashiagr requested a review from a team as a code owner November 21, 2022 07:51
geekygecko
geekygecko approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@geekygecko geekygecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. 🙏

@geekygecko geekygecko merged commit c5a8705 into main Nov 21, 2022
@geekygecko geekygecko deleted the task/410-retry branch November 21, 2022 08:26
@ashiagr ashiagr mentioned this pull request Nov 24, 2022
Merged
@ashiagr ashiagr added this to the 7.27 ❄️ milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekygecko geekygecko geekygecko approved these changes

Assignees
No one assigned
Labels
[Project] End of Year
Projects
None yet
Milestone
7.27
Development

Successfully merging this pull request may close these issues.
2 participants
@ashiagr @geekygecko