Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/folder sync issue #216

Merged
merged 3 commits into from
Aug 8, 2022
Merged

Fix/folder sync issue #216

merged 3 commits into from
Aug 8, 2022

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Aug 8, 2022 •
edited
Loading

Description

This PR cherry picks already approved changes in #214 for a hot fix.

Checklist

  • Should this change be included in the release notes? If yes, please add a line in RELEASE-NOTES.md
  • Have you tested in landscape?
  • Have you tested accessibility with TalkBack?
  • Have you tested in different themes?
  • Does the change work with a large display font?
  • Are all the strings localized?
  • Could you have written any new tests?
  • Did you include Compose previews with any components?

@mchowning
Copy link
Contributor

mchowning commented Aug 8, 2022 •
edited
Loading

Do we want to also take care of updating the version in dependencies.gradle to 7.20.3 in this PR:

versionName = '7.20.2' + getVersionNameSuffix()

@ashiagr ashiagr marked this pull request as ready for review August 8, 2022 13:00
@ashiagr ashiagr requested a review from a team as a code owner August 8, 2022 13:00
@ashiagr
Copy link
Contributor Author

ashiagr commented Aug 8, 2022

Good point. I updated it in 8aa743f.

mchowning
mchowning approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and is working well. Thanks for tackling this @ashiagr ! 🙇

@mchowning mchowning merged commit 4d053e8 into release/7.20.3 Aug 8, 2022
@mchowning mchowning deleted the fix/folder-sync-issue branch August 8, 2022 13:53
This was referenced Aug 8, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashiagr @mchowning