Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix folder mapping #214

Merged
merged 3 commits into from
Aug 8, 2022
Merged

Fix folder mapping #214

merged 3 commits into from
Aug 8, 2022

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Aug 8, 2022

Description

This PR fixes folder mapping during folders full sync at the time of clean install and login.

See internal discussion: p1659697659512559/1659608112.261529-slack-C028JAG44VD for more details.

How to test?

  1. Create a fresh account and gift plus plan to it.
  2. Create a folder on device using this account and add a podcast to it (make sure not to assign color / podcasts sort type / sort order to the folder).
  3. Sync folder to server and make sure it is shown in web interface.
  4. Logout from device + clear storage.
  5. Login to account on device.
  6. ✅ Go to Podcasts tab, notice that folder is shown with podcast inside it.

Checklist

  • Should this change be included in the release notes? If yes, please add a line in RELEASE-NOTES.md
  • Have you tested in landscape?
  • Have you tested accessibility with TalkBack?
  • Have you tested in different themes?
  • Does the change work with a large display font?
  • Are all the strings localized?
  • Could you have written any new tests?
  • Did you include Compose previews with any components?

@ashiagr ashiagr marked this pull request as ready for review August 8, 2022 07:05
@ashiagr ashiagr requested a review from a team as a code owner August 8, 2022 07:05
@geekygecko geekygecko merged commit f192f9f into main Aug 8, 2022
@geekygecko geekygecko deleted the fix/server-folder-mapping branch August 8, 2022 11:16
@ashiagr ashiagr mentioned this pull request Aug 8, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants