Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop fixes and configuration update #1392

Merged
merged 10 commits into from
Nov 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
inherit_from: .rubocop_todo.yml

AllCops:
Exclude:
- vendor/**/*
Expand All @@ -7,15 +9,24 @@ Layout/LineLength:
Max: 180
Exclude:
- fastlane/Fastfile
- scripts/themes/download_themes.rb
- scripts/themes/generate_themes.rb
- scripts/themes/generate_kotlin.rb

Metrics/BlockLength:
Exclude:
- fastlane/Fastfile
- scripts/themes/download_themes.rb
- scripts/themes/generate_themes.rb
- scripts/themes/generate_kotlin.rb

Metrics/MethodLength:
Max: 30
Exclude:
- fastlane/Fastfile
- scripts/themes/download_themes.rb
- scripts/themes/generate_themes.rb
- scripts/themes/generate_kotlin.rb

Style/HashSyntax:
EnforcedShorthandSyntax: never
37 changes: 37 additions & 0 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2023-09-20 10:40:52 UTC using RuboCop version 1.56.3.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 3
# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
Metrics/AbcSize:
Max: 75

# Offense count: 1
# Configuration parameters: CountBlocks.
Metrics/BlockNesting:
Max: 4

# Offense count: 2
# Configuration parameters: AllowedMethods, AllowedPatterns.
Metrics/CyclomaticComplexity:
Max: 26

# Offense count: 1
# Configuration parameters: AllowedMethods, AllowedPatterns.
Metrics/PerceivedComplexity:
Max: 33

# Offense count: 3
# Configuration parameters: AllowedConstants.
Style/Documentation:
Exclude:
- 'spec/**/*'
- 'test/**/*'
- 'scripts/themes/download_themes.rb'
- 'scripts/themes/generate_kotlin.rb'
- 'scripts/themes/generate_kotlin_compose.rb'
6 changes: 3 additions & 3 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
GIT
remote: https://github.com/Automattic/dangermattic
revision: 8406e79e3b20e71421462a525c50a0525da697aa
revision: 06a54db4f546d20c0465e4d144049d061a2a1e20
specs:
danger-dangermattic (0.0.1)
danger (~> 9.3)
Expand Down Expand Up @@ -33,7 +33,7 @@ GEM
atomos (0.1.3)
aws-eventstream (1.2.0)
aws-partitions (1.843.0)
aws-sdk-core (3.185.1)
aws-sdk-core (3.185.2)
aws-eventstream (~> 1, >= 1.0.2)
aws-partitions (~> 1, >= 1.651.0)
aws-sigv4 (~> 1.5)
Expand Down Expand Up @@ -284,7 +284,7 @@ GEM
highline (>= 1.6, < 3)
options (~> 2.3.0)
public_suffix (5.0.3)
racc (1.7.1)
racc (1.7.3)
rainbow (3.1.1)
rake (13.1.0)
rake-compiler (1.2.5)
Expand Down
Loading