Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubocop fixes and configuration update #1392

Merged
merged 10 commits into from
Nov 27, 2023
Merged

Rubocop fixes and configuration update #1392

merged 10 commits into from
Nov 27, 2023

Conversation

iangmaia
Copy link
Contributor

This PR builds on top of #1391, fixing most of the reported Rubocop offences.

Some of the offences could be a bit riskier to quickly fix and didn't seem very critical, so I generated a .rubocop_todo.yml to silence them for now.

@iangmaia iangmaia force-pushed the add/dangermattic-setup branch from 697106a to bd3be19 Compare September 20, 2023 16:31
@iangmaia iangmaia changed the title Rubocop fixes and configuration improvements Rubocop fixes and configuration update Sep 21, 2023
@iangmaia iangmaia force-pushed the add/dangermattic-setup branch from bd3be19 to 0edafcf Compare October 5, 2023 18:43
@iangmaia iangmaia force-pushed the add/dangermattic-setup branch from 0edafcf to 0ed4112 Compare October 13, 2023 08:20
@iangmaia iangmaia force-pushed the add/dangermattic-setup branch from 0ed4112 to 8dcf74d Compare October 13, 2023 09:16
@iangmaia iangmaia force-pushed the add/dangermattic-setup branch from 8dcf74d to 604a7d9 Compare October 23, 2023 12:51
@Automattic Automattic deleted a comment from wpmobilebot Oct 23, 2023
@iangmaia iangmaia force-pushed the add/dangermattic-setup branch from 1a95001 to d6b1bb1 Compare October 24, 2023 10:15
@iangmaia iangmaia force-pushed the add/rubocop branch 3 times, most recently from 8d51009 to 6845f76 Compare October 26, 2023 09:08
@iangmaia iangmaia added the [Type] Tooling Related to the Gradle build scripts and the setup or maintenance of the project build process. label Oct 26, 2023
@iangmaia iangmaia marked this pull request as ready for review October 26, 2023 18:00
@iangmaia iangmaia requested a review from a team as a code owner October 26, 2023 18:00
@iangmaia iangmaia force-pushed the add/dangermattic-setup branch from f8c2675 to 38e9a3c Compare October 30, 2023 19:04
@iangmaia iangmaia force-pushed the add/rubocop branch 2 times, most recently from 3592b7d to d2b0c67 Compare October 31, 2023 08:46
Base automatically changed from add/dangermattic-setup to main November 1, 2023 10:02
@iangmaia iangmaia enabled auto-merge (squash) November 1, 2023 15:09
@iangmaia iangmaia added this to the 7.52 milestone Nov 6, 2023
@pocketcasts
Copy link

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@ashiagr ashiagr modified the milestones: 7.52, 7.53 Nov 13, 2023
@iangmaia iangmaia merged commit 21053a2 into main Nov 27, 2023
@iangmaia iangmaia deleted the add/rubocop branch November 27, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashiagr ashiagr ashiagr approved these changes

Assignees
No one assigned
Labels
[Type] Tooling Related to the Gradle build scripts and the setup or maintenance of the project build process.
Projects
None yet
Milestone
7.53
Development

Successfully merging this pull request may close these issues.
3 participants
@iangmaia @pocketcasts @ashiagr