-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings Sync - Refactor archive settings to be UserSettings #1234
Settings Sync - Refactor archive settings to be UserSettings #1234
Conversation
@@ -1,3 +1,9 @@ | |||
Unknown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this won't be in 7.45, so putting this here in order to create a merge conflict when this gets merged to main
. At that point, I'll add this release note under the correct release heading.
output.append("Auto archive played episodes after: " + afterPlaying[settings.getAutoArchiveAfterPlaying().toIndex()]).append(eol) | ||
output.append("Auto archive inactive episodes after: " + inactive[settings.getAutoArchiveInactive().toIndex()]).append(eol) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this to no longer use localized strings here since localized strings just seem like they would make things more difficult for support. I'm using the analytics value because that seemed good enough, but if you think we'd be better off creating some even-more-readable support-specific strings, let me know.
All tests pass.
Thank you for fixing it 🙇♀️ I've verified that it works correctly now. |
Description
This updates the archive settings to be user settings.
In doing this, I found that we were persisting some of the archive settings as localized strings. Not surprisingly, this can cause some issues when a user changes the language on their phone. This PR fixes this by migrating the settings to a new key in shared preferences that is no longer tied to the app's language.
I also updated our support logs so that the auto archive settings are no longer displayed with a localized string.
Testing Instructions
1. General refactor testing
For each setting in the "Auto Archive" section:
2. Language change bug fix
3. Migration of archive settings
main
4. Support logs no longer use localized strings for archive settings
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml