Storage choice is persisted as localized string

[mchowning]

Description

When selecting a storage choice in the "Storage & data use" section of the app's settings, we are saving (and retrieving) the localized label for the storage choice. This means that if you set a storage choice with the OS under one language, and then switch the OS to a different language, the rest of the app updates to the new language, but your storage choice is still displayed in the previous language.

This is occurring because we persist (and retrieve) the localized label for the storage choice in Shared Preferences under the Settings.PREFERENCE_STORAGE_CHOICE key.

Step-by-step reproduction instructions

1. Go to the Profile tab → ⚙️ → "Storage & data use"
2. Select an option under "Store podcasts on"
3. Switch the language the OS is using
4. 💥 Observe that the selected option under "Store podcasts on" is still in the previous language.

Screenshots or screen recording

device-2023-01-30-173349.webm

Did you search for existing bug reports?

• I have searched for existing bug reports.

Device, Operating system, and Pocket Casts app version

Pixel 4 emulator running Android api 24, Pocket Casts 7.31 pre-release build.

[mchowning]

This same issue was also occuring with the "Archive played episodes" and "Archive inactive episodes" settings and our users would lose their custom settings when switching languages. I will have a fix up for this shortly.

UPDATE: This has been fixed

Video

Screen.Recording.2023-08-02.at.6.44.15.PM.mov