Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to auto download on watch #1212

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Remove references to auto download on watch #1212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc3a118
Remove references to auto download on watch
mchowning Jul 27, 2023
e6daf95
Update changelog
mchowning Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
([#1209](https://github.com/Automattic/pocket-casts-android/pull/1209))
* Fixed upgrade flow when signing in with Google account
([#1204](https://github.com/Automattic/pocket-casts-android/pull/1204))

* Fixed watch background refresh description to not reference auto downloads
([#1212](https://github.com/Automattic/pocket-casts-android/pull/1212))

7.44
-----
Expand Down
2 changes: 2 additions & 0 deletions modules/services/localization/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1188,7 +1188,9 @@
<string name="settings_storage_android_10_custom">We can no longer support custom folders for storage on Android 10+. We have switched your storage option back to your phones default.</string>
<string name="settings_storage_background_refresh">Background refresh</string>
<string name="settings_storage_background_refresh_off">Pocket Casts will only refresh when you open the app.\n\nEpisode notifications and auto downloads will only happen when you open the app.</string>
<string name="settings_storage_background_refresh_off_watch">Pocket Casts will only sync your account when you open the app.</string>
<string name="settings_storage_background_refresh_on">Pocket Casts will periodically check for new episodes and auto downloads in the background.</string>
<string name="settings_storage_background_refresh_on_watch">Pocket Casts will periodically sync your account in the background.</string>
<string name="settings_storage_clear_cache">Clearing download cache</string>
<string name="settings_storage_clear_download_cache">Clear download cache</string>
<string name="settings_storage_custom_folder">Custom Folder</string>
Expand Down
8 changes: 6 additions & 2 deletions wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/settings/SettingsScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,12 @@ private fun Content(
)
}

val backgroundRefreshStringRes =
if (state.refreshInBackground) LR.string.settings_storage_background_refresh_on else LR.string.settings_storage_background_refresh_off
val backgroundRefreshStringRes = if (state.refreshInBackground) {
LR.string.settings_storage_background_refresh_on_watch
} else {
LR.string.settings_storage_background_refresh_off_watch
}

item {
ToggleChip(
label = stringResource(LR.string.settings_storage_background_refresh),
Expand Down