Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to auto download on watch #1212

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Jul 27, 2023

Description

For the refresh setting we were reusing strings from the app on the watch and they included references to auto download, which does not happen on the watch (yet). This updates those strings to not reference auto downloading.

In addition, I took this opportunity to shorten the strings since the watch screen is so small.

Testing Instructions

  1. Open the settings on the watch
  2. Verify that the text below the "Background refresh" toggle makes sense both when the setting is toggled on and when it is toggled off.

Screenshots or Screencast

Before After
Screenshot 2023-07-27 at 10 51 11 AM Screenshot 2023-07-27 at 1 34 54 PM
Screenshot 2023-07-27 at 11 00 48 AM Screenshot 2023-07-27 at 1 40 31 PM

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@mchowning mchowning added the [Area] Wear OS watch app label Jul 27, 2023
@mchowning mchowning force-pushed the fix/wear-background-refresh-description branch from b4ec2c3 to 98ed068 Compare July 27, 2023 17:39
@mchowning mchowning force-pushed the fix/wear-background-refresh-description branch from 98ed068 to e6daf95 Compare July 27, 2023 17:40
@mchowning mchowning marked this pull request as ready for review July 27, 2023 17:41
@mchowning mchowning requested a review from a team as a code owner July 27, 2023 17:41
@ashiagr ashiagr merged commit 5a01c9d into main Jul 28, 2023
@ashiagr ashiagr deleted the fix/wear-background-refresh-description branch July 28, 2023 05:37
@ashiagr ashiagr added this to the 7.45 ❄️ milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants