Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump recycler view version #1205

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Bump recycler view version #1205

merged 3 commits into from
Jul 25, 2023

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Jul 25, 2023

Description

This bumps recycler view version to stable v1.3.0.

It also removes unused view holders and removes DisposeOnViewTreeLifecycleDestroyed and ViewCompositionStrategy described in the previous interoperability guidelines from FolderViewHolder as described in the release notes.

Testing Instructions

  • Smoke test folders list.
  • Check for any view holders that might be using previous interoperability guidelines.

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr added the [Type] Tech Debt Involving upgrades or refactoring to maintain or enhance the codebase. label Jul 25, 2023
@ashiagr ashiagr requested a review from a team as a code owner July 25, 2023 13:50
mchowning
mchowning approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@mchowning mchowning enabled auto-merge (squash) July 25, 2023 14:17
@mchowning mchowning merged commit 1e3db07 into main Jul 25, 2023
@mchowning mchowning deleted the task/update-recycler-view branch July 25, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

Assignees
No one assigned
Labels
[Type] Tech Debt Involving upgrades or refactoring to maintain or enhance the codebase.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashiagr @mchowning