Bump recycler view version (#1205)

Automattic · Jul 25, 2023 · 1e3db07 · 1e3db07
1 parent 619924e
commit 1e3db07
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 83 deletions.
diff --git a/dependencies.gradle b/dependencies.gradle
@@ -119,7 +119,7 @@ project.ext {
             auth: "com.google.android.gms:play-services-auth:20.4.0",
             mediarouter: "androidx.mediarouter:mediarouter:1.3.1",
             palette: "androidx.palette:palette:1.0.0",
-            recyclerview: "androidx.recyclerview:recyclerview:1.2.1",
+            recyclerview: "androidx.recyclerview:recyclerview:1.3.0",
             swipeToRefresh: "androidx.swiperefreshlayout:swiperefreshlayout:1.1.0",
             design: "com.google.android.material:material:1.5.0",
             cardview: "androidx.cardview:cardview:1.0.0",

diff --git a/...asts/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/podcasts/FolderAdapter.kt b/...asts/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/podcasts/FolderAdapter.kt
@@ -95,9 +95,6 @@ class FolderAdapter(
                     holder.podcastThumbnail.setImageDrawable(null)
                 }
             }
-            is FolderViewHolder -> {
-                holder.composeView.disposeComposition()
-            }
         }
     }
 

diff --git a/...s/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/podcasts/FolderViewHolder.kt b/...s/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/podcasts/FolderViewHolder.kt
@@ -8,7 +8,6 @@ import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.platform.ComposeView
-import androidx.compose.ui.platform.ViewCompositionStrategy
 import androidx.compose.ui.unit.dp
 import androidx.recyclerview.widget.RecyclerView
 import au.com.shiftyjelly.pocketcasts.compose.AppTheme
@@ -29,12 +28,6 @@ class FolderViewHolder(
     val onFolderClick: (Folder) -> Unit
 ) : RecyclerView.ViewHolder(composeView) {
 
-    init {
-        composeView.setViewCompositionStrategy(
-            ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed
-        )
-    }
-
     fun bind(folder: Folder, podcasts: List<Podcast>, badgeType: Settings.BadgeType, podcastUuidToBadge: Map<String, Int>) {
         val badgeCount = calculateFolderBadge(podcasts, badgeType, podcastUuidToBadge)
 

diff --git a/...rch/src/main/java/au/com/shiftyjelly/pocketcasts/search/adapter/SearchFolderViewHolder.kt b/...rch/src/main/java/au/com/shiftyjelly/pocketcasts/search/adapter/SearchFolderViewHolder.kt
diff --git a/...ch/src/main/java/au/com/shiftyjelly/pocketcasts/search/adapter/SearchPodcastViewHolder.kt b/...ch/src/main/java/au/com/shiftyjelly/pocketcasts/search/adapter/SearchPodcastViewHolder.kt
-Original file line number
+Diff line change
@@ Expand Up / @@ -95,9 +95,6 @@ class FolderAdapter( @@
                         holder.podcastThumbnail.setImageDrawable(null)
                     }
                 }
-                is FolderViewHolder -> {
-                    holder.composeView.disposeComposition()
-                }
             }
         }
@@ Expand Down @@