Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue to upgrade screen from google sign in when appropriate #1204

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Jul 25, 2023

Description

This fixes the onboarding flow when someone clicks an upgrade prompt and then logs into a free account using Google. See #1184 for more info.

Fixes #1184

Testing Instructions

If you test this on a debug build, note that tapping on the "Upgrade to Plus" button can freeze the app if you're already logged in (#1158). Also note that the upgrade screen won't have any subscription options unless you make the changes needed to pull in subscriptions (which are not needed to test this PR).

1. Fixes upgrade flow

  1. Fresh install of the app
  2. Go to Profile tab → ⚙️ → Pocket Casts Plus
  3. Tap on "Upgrade to Plus"
  4. Tap "Continue with Google"
  5. Log into an already existing free Pocket Casts account
  6. ✅ Observe that you are taken to the onboarding flow's upgrade screen.

2. Check for regressions

2a. Upgrading and creating a new Pocket Casts account with Google sign in

  1. Fresh install of the app
  2. Go to Profile tab → ⚙️ → Pocket Casts Plus
  3. Tap on "Upgrade to Plus"
  4. Tap "Continue with Google"
  5. Create a new Pocket Casts account (i.e., select a Google login that is not associated with a PC account already)
  6. ✅ Observe that you are taken to the recommendations screen in the onboarding flow.

2b. Signing into a free account using Google outside the upgrade flow

  1. Fresh install of the app
  2. Tap "Continue with Google"
  3. Create a new Pocket Casts account (i.e., select a Google login that is not associated with a PC account already)
  4. ✅ Observe that you are taken to the recommendations screen in the onboarding flow.

2c. Creating a new Google account in the regular onboarding flow

  1. Fresh install of the app
  2. Tap "Continue with Google"
  3. Log into an already existing free Pocket Casts account
  4. ✅ Observe that you are taken out of the onboarding flow and into the app

Screenshots or Screencast

Screen.Recording.2023-07-25.at.9.03.56.AM.mov

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

@mchowning mchowning marked this pull request as ready for review July 25, 2023 13:54
@mchowning mchowning requested a review from a team as a code owner July 25, 2023 13:54
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in my testing 👍
Great fix!

@ashiagr ashiagr enabled auto-merge (squash) July 27, 2023 09:59
@ashiagr ashiagr merged commit 63cbc99 into main Jul 27, 2023
@ashiagr ashiagr deleted the fix/upgrade-flow-with-google-login branch July 27, 2023 10:32
@ashiagr ashiagr added this to the 7.45 ❄️ milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continuing with Google in Upgrade flow exiting without upgrade prompt
2 participants