Continue to upgrade screen from google sign in when appropriate #1204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the onboarding flow when someone clicks an upgrade prompt and then logs into a free account using Google. See #1184 for more info.
Fixes #1184
Testing Instructions
If you test this on a debug build, note that tapping on the "Upgrade to Plus" button can freeze the app if you're already logged in (#1158). Also note that the upgrade screen won't have any subscription options unless you make the changes needed to pull in subscriptions (which are not needed to test this PR).
1. Fixes upgrade flow
Profile
tab → ⚙️ → Pocket Casts Plus2. Check for regressions
2a. Upgrading and creating a new Pocket Casts account with Google sign in
Profile
tab → ⚙️ → Pocket Casts Plus2b. Signing into a free account using Google outside the upgrade flow
2c. Creating a new Google account in the regular onboarding flow
Screenshots or Screencast
Screen.Recording.2023-07-25.at.9.03.56.AM.mov
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml