Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuing with Google in Upgrade flow exiting without upgrade prompt #1184

Closed
1 task done
mchowning opened this issue Jul 19, 2023 · 1 comment · Fixed by #1204
Closed
1 task done

Continuing with Google in Upgrade flow exiting without upgrade prompt #1184

mchowning opened this issue Jul 19, 2023 · 1 comment · Fixed by #1204
Assignees
Labels
[Priority] High Requires immediate attention [Type] Bug Not functioning as intended.

Comments

@mchowning
Copy link
Contributor

Description

If a non-logged in user goes through the upgrade flow using "Continue with Google" to log in to a pre-existing non-Plus account, the flow ends immediately after logging them in instead of providing the upgrade screens. We should be showing the upgrade screens in this flow.

If the user in that scenario is creating a new account with "Continue with Google" (instead of logging into a pre-existing account) then the flow works as it should (i.e., it prompts them to upgrade). Likewise, if the user creates a new account with email/password, the flow works as it should.

In other words, this is only an issue for users who try to upgrade when they are not logged in, and they then proceed to log into a pre-existing account using Google sign in. Users who encounter this issue can then just click the "Start free trial" button on the Plus screen a second time, and they are permitted to upgrade.

Step-by-step reproduction instructions

  1. Fresh install of production build of the app
  2. Go to the Profile Tab → ⚙️ → Pocket Casts Plus
  3. Tap on "Start free trial"
  4. Tap "Continue with Google"
  5. Select a Google account that is already associated with a non-Plus Pocket Casts account
  6. 💥 Observe that you are logged in and returned to the "Pocket Casts Plus" screen with the "Start free trial" button without ever having been shown the upgrade options.
  7. Tap on the "Start free trial" button again
  8. Observe that you are presented with a bottom sheet showing the upgrade options.

Screenshots or screen recording

Screen.Recording.2023-07-19.at.9.25.32.AM.mov

Did you search for existing bug reports?

  • I have searched for existing bug reports.

Device, Operating system, and Pocket Casts app version

Samsung A13, Android 13, Pocket Casts 7.41 and 7.43-rc-3

@mchowning mchowning added [Type] Bug Not functioning as intended. [Priority] High Requires immediate attention labels Jul 19, 2023
@mchowning
Copy link
Contributor Author

Marking this issue as high priority even though it is unlikely to impact many users (most users are probably not trying to upgrade their already existing accounts when they're not logged into any account), and does not block users (the second time they tap the upgrade prompt it works fine), because it is adding friction to our upgrade flow.

@mchowning mchowning changed the title Continuing with Google in Upgrade flow not working Continuing with Google in Upgrade flow exiting before upgrade prompt Jul 19, 2023
@mchowning mchowning changed the title Continuing with Google in Upgrade flow exiting before upgrade prompt Continuing with Google in Upgrade flow exiting without upgrade prompt Jul 19, 2023
@mchowning mchowning self-assigned this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] High Requires immediate attention [Type] Bug Not functioning as intended.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant