-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General: update requirements to match upcoming WP 6.0 release #24083
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
Backup plugin:
Vaultpress plugin:
Boost plugin:
Search plugin:
Social plugin:
Starter Plugin plugin:
Protect plugin:
|
See https://make.wordpress.org/core/2021/11/10/default-git-branch-for-wordpress-wordpress-develop/ That means our master tests have not really been running on the latest dev version of WordPress since last november. :|
I'll work on landing 24224 right now so we can have this ready to merge at the same time as the #23908 to avoid folks having to bump their PRs too many times. |
Great news! One last step: head over to your WordPress.com diff, D79510-code, and deploy it. Thank you! |
* General: update requirements to match upcoming WP 6.0 release See #24082 * Update minimum version required in Jetpack * WordPress' git repos now use trunk instead of master See https://make.wordpress.org/core/2021/11/10/default-git-branch-for-wordpress-wordpress-develop/ That means our master tests have not really been running on the latest dev version of WordPress since last november. :| * Update array of valid WP branches * Update menu order id rounding See https://core.trac.wordpress.org/ticket/40927 * Set up custom stats key values in tests depending on WP version See https://core.trac.wordpress.org/ticket/40927 * Do not run failing tests on WordPress.com for now See Automattic/jetpack#24083 (comment) * Update to use ID instead of id Co-authored-by: Brandon Kraft <[email protected]> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/2264920263
* General: update requirements to match upcoming WP 6.0 release See #24082 * Update minimum version required in Jetpack * WordPress' git repos now use trunk instead of master See https://make.wordpress.org/core/2021/11/10/default-git-branch-for-wordpress-wordpress-develop/ That means our master tests have not really been running on the latest dev version of WordPress since last november. :| * Update array of valid WP branches * Update menu order id rounding See https://core.trac.wordpress.org/ticket/40927 * Set up custom stats key values in tests depending on WP version See https://core.trac.wordpress.org/ticket/40927 * Do not run failing tests on WordPress.com for now See Automattic/jetpack#24083 (comment) * Update to use ID instead of id Co-authored-by: Brandon Kraft <[email protected]> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/2264920263
* General: update requirements to match upcoming WP 6.0 release See #24082 * Update minimum version required in Jetpack * WordPress' git repos now use trunk instead of master See https://make.wordpress.org/core/2021/11/10/default-git-branch-for-wordpress-wordpress-develop/ That means our master tests have not really been running on the latest dev version of WordPress since last november. :| * Update array of valid WP branches * Update menu order id rounding See https://core.trac.wordpress.org/ticket/40927 * Set up custom stats key values in tests depending on WP version See https://core.trac.wordpress.org/ticket/40927 * Do not run failing tests on WordPress.com for now See Automattic/jetpack#24083 (comment) * Update to use ID instead of id Co-authored-by: Brandon Kraft <[email protected]> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/2264920263
* General: update requirements to match upcoming WP 6.0 release See #24082 * Update minimum version required in Jetpack * WordPress' git repos now use trunk instead of master See https://make.wordpress.org/core/2021/11/10/default-git-branch-for-wordpress-wordpress-develop/ That means our master tests have not really been running on the latest dev version of WordPress since last november. :| * Update array of valid WP branches * Update menu order id rounding See https://core.trac.wordpress.org/ticket/40927 * Set up custom stats key values in tests depending on WP version See https://core.trac.wordpress.org/ticket/40927 * Do not run failing tests on WordPress.com for now See Automattic/jetpack#24083 (comment) * Update to use ID instead of id Co-authored-by: Brandon Kraft <[email protected]> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/2264920263
* General: update requirements to match upcoming WP 6.0 release See #24082 * Update minimum version required in Jetpack * WordPress' git repos now use trunk instead of master See https://make.wordpress.org/core/2021/11/10/default-git-branch-for-wordpress-wordpress-develop/ That means our master tests have not really been running on the latest dev version of WordPress since last november. :| * Update array of valid WP branches * Update menu order id rounding See https://core.trac.wordpress.org/ticket/40927 * Set up custom stats key values in tests depending on WP version See https://core.trac.wordpress.org/ticket/40927 * Do not run failing tests on WordPress.com for now See Automattic/jetpack#24083 (comment) * Update to use ID instead of id Co-authored-by: Brandon Kraft <[email protected]> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/2264920263
* General: update requirements to match upcoming WP 6.0 release See #24082 * Update minimum version required in Jetpack * WordPress' git repos now use trunk instead of master See https://make.wordpress.org/core/2021/11/10/default-git-branch-for-wordpress-wordpress-develop/ That means our master tests have not really been running on the latest dev version of WordPress since last november. :| * Update array of valid WP branches * Update menu order id rounding See https://core.trac.wordpress.org/ticket/40927 * Set up custom stats key values in tests depending on WP version See https://core.trac.wordpress.org/ticket/40927 * Do not run failing tests on WordPress.com for now See Automattic/jetpack#24083 (comment) * Update to use ID instead of id Co-authored-by: Brandon Kraft <[email protected]> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/2264920263
* General: update requirements to match upcoming WP 6.0 release See #24082 * Update minimum version required in Jetpack * WordPress' git repos now use trunk instead of master See https://make.wordpress.org/core/2021/11/10/default-git-branch-for-wordpress-wordpress-develop/ That means our master tests have not really been running on the latest dev version of WordPress since last november. :| * Update array of valid WP branches * Update menu order id rounding See https://core.trac.wordpress.org/ticket/40927 * Set up custom stats key values in tests depending on WP version See https://core.trac.wordpress.org/ticket/40927 * Do not run failing tests on WordPress.com for now See Automattic/jetpack#24083 (comment) * Update to use ID instead of id Co-authored-by: Brandon Kraft <[email protected]> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/2264920263
r244861-wpcom |
Noting the Perk is older versions of Jetpack won't face any oddities due to the original issue. https://core.trac.wordpress.org/changeset/53362 |
…release (#24083) * General: update requirements to match upcoming WP 6.0 release See #24082 * Update minimum version required in Jetpack * WordPress' git repos now use trunk instead of master See https://make.wordpress.org/core/2021/11/10/default-git-branch-for-wordpress-wordpress-develop/ That means our master tests have not really been running on the latest dev version of WordPress since last november. :| * Update array of valid WP branches * Update menu order id rounding See https://core.trac.wordpress.org/ticket/40927 * Set up custom stats key values in tests depending on WP version See https://core.trac.wordpress.org/ticket/40927 * Do not run failing tests on WordPress.com for now See #24083 (comment) * Update to use ID instead of id Co-authored-by: Brandon Kraft <[email protected]>
Cherry-picked to |
Packages were updated in the release branch in d800479 |
When WordPress core renamed their main branch from "master" to "trunk", first we didn't notice for several months. Then when we changed things over in #24083, we overlooked changing the Jetpack test-running script that was only running the multisite tests against WP "master" to run against "trunk" instead.
When WordPress core renamed their main branch from "master" to "trunk", first we didn't notice for several months. Then when we changed things over in #24083, we overlooked changing the Jetpack test-running script that was only running the multisite tests against WP "master" to run against "trunk" instead.
Changes proposed in this Pull Request:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: