Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordPress 6.0 compatibility #24082

Closed
6 tasks done
jeherve opened this issue Apr 26, 2022 · 2 comments
Closed
6 tasks done

WordPress 6.0 compatibility #24082

jeherve opened this issue Apr 26, 2022 · 2 comments
Assignees
@jeherve
Labels
Epic Formerly "Primary Issue", or "Master Issue" General [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Janitorial
Milestone
jetpack/10.9.1

Comments

@jeherve
Copy link
Member

jeherve commented Apr 26, 2022 •
edited
Loading

WordPress 6.0 is set to release on May 24, 2022.
https://make.wordpress.org/core/6-0/

We consequently need to ensure that Jetpack is fully compatible with this new release by Jetpack 10.9, scheduled to be released in early May.

If not possible, maybe we could push a new release a few days before May 24, maybe the week before on May 17?

@kraftbj What's your take on this?

In addition to the above, we can follow the dev-notes that will drop here about the release:
https://make.wordpress.org/core/tag/dev-notes+6-0

For reference: prior art for WordPress 5.9 compat: #21322
Internal: p9dueE-4XE-p2
@jeherve jeherve added General [Type] Janitorial Epic Formerly "Primary Issue", or "Master Issue" [Pri] Normal [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Apr 26, 2022
@jeherve jeherve added this to the jetpack/11.0 milestone Apr 26, 2022
@jeherve jeherve self-assigned this Apr 26, 2022
@jeherve jeherve mentioned this issue Apr 26, 2022
Merged
jeherve added a commit that referenced this issue Apr 26, 2022
@jeherve
General: update requirements to match upcoming WP 6.0 release
6ecb0f9 
See #24082
@kraftbj kraftbj modified the milestones: jetpack/11.0, jetpack/10.9.1 Apr 26, 2022
@kraftbj
Copy link
Contributor

kraftbj commented Apr 26, 2022

If not possible, maybe we could push a new release a few days before May 24, maybe the week before on May 17?

I fully support a release out of cycle if there's anything critical to ensure compatibility. I think we can treat it as a point release (cherry-picking anything needed for compact). With it being a late-in-the-month release and the majority of the field notes for 6.0 not published, I don't think we should push ourselves to make 10.9 deemed compat.

@jeherve jeherve mentioned this issue Apr 26, 2022
Merged
jeherve added a commit that referenced this issue Apr 26, 2022
@jeherve
Update PHPUnit setup to remove WP < 5.9 oddities
cde8ba3 
See #21175, #21157

Primary issue: #24082
@jeherve jeherve mentioned this issue May 3, 2022
Merged
kraftbj added a commit that referenced this issue May 3, 2022
@jeherve @kraftbj
General: update requirements to match upcoming WP 6.0 release (#24083)
4d0acf4 
* General: update requirements to match upcoming WP 6.0 release

See #24082

* Update minimum version required in Jetpack

* WordPress' git repos now use trunk instead of master

See https://make.wordpress.org/core/2021/11/10/default-git-branch-for-wordpress-wordpress-develop/

That means our master tests have not really been running on the latest dev version of WordPress since last november. :|

* Update array of valid WP branches

* Update menu order id rounding

See https://core.trac.wordpress.org/ticket/40927

* Set up custom stats key values in tests depending on WP version

See https://core.trac.wordpress.org/ticket/40927

* Do not run failing tests on WordPress.com for now

See #24083 (comment)

* Update to use ID instead of id

Co-authored-by: Brandon Kraft <[email protected]>
jeherve added a commit that referenced this issue May 3, 2022
@jeherve @anomiex @kraftbj
General: remove backwards compatibility code now that Jetpack require…
b98c640 
…s WP 5.9 (#24086)

* General: remove backwards compatibility code for user queries

See #22559

* Update PHPUnit setup to remove WP < 5.9 oddities

See #21175, #21157

Primary issue: #24082

* Update docs/examples/bootstrap.php

Co-authored-by: Brad Jorsch <[email protected]>

* Remove speed trap listener loder

* Update doc to remove mention of temporary PHPUnit situation

* Remove temporary line break workaround

See #15595

* Remove custom function in favor of the one that ships with core

* Remove old workaround for the Jetpack sidebar plugin icon

See #14327

* Remove PHP 5.2 workaround

See 99fffd8

* Add back necessary _wp_specialchars wrapping

Co-authored-by: Brad Jorsch <[email protected]>
Co-authored-by: Brandon Kraft <[email protected]>
@kraftbj
Copy link
Contributor

kraftbj commented May 7, 2022

Noting that we updated Sync to work with a change in WP 6.0. That was reported upstream and resolved. We don't need to revert our change, but previous versions of Jetpack should not be impacted (assuming a second committer approves to cherry pick the changeset to the 6.0 branch)

https://core.trac.wordpress.org/changeset/53362

@jeherve jeherve closed this as completed May 19, 2022
jeherve added a commit that referenced this issue May 19, 2022
@jeherve @kraftbj
[not verified] General: update requirements to match upcoming WP 6.0 …
a0b9931 
…release (#24083)

* General: update requirements to match upcoming WP 6.0 release

See #24082

* Update minimum version required in Jetpack

* WordPress' git repos now use trunk instead of master

See https://make.wordpress.org/core/2021/11/10/default-git-branch-for-wordpress-wordpress-develop/

That means our master tests have not really been running on the latest dev version of WordPress since last november. :|

* Update array of valid WP branches

* Update menu order id rounding

See https://core.trac.wordpress.org/ticket/40927

* Set up custom stats key values in tests depending on WP version

See https://core.trac.wordpress.org/ticket/40927

* Do not run failing tests on WordPress.com for now

See #24083 (comment)

* Update to use ID instead of id

Co-authored-by: Brandon Kraft <[email protected]>
jeherve added a commit that referenced this issue May 19, 2022
@jeherve @anomiex @kraftbj
[not verified] General: remove backwards compatibility code now that …
04b8ad7 
…Jetpack requires WP 5.9 (#24086)

* General: remove backwards compatibility code for user queries

See #22559

* Update PHPUnit setup to remove WP < 5.9 oddities

See #21175, #21157

Primary issue: #24082

* Update docs/examples/bootstrap.php

Co-authored-by: Brad Jorsch <[email protected]>

* Remove speed trap listener loder

* Update doc to remove mention of temporary PHPUnit situation

* Remove temporary line break workaround

See #15595

* Remove custom function in favor of the one that ships with core

* Remove old workaround for the Jetpack sidebar plugin icon

See #14327

* Remove PHP 5.2 workaround

See 99fffd8

* Add back necessary _wp_specialchars wrapping

Co-authored-by: Brad Jorsch <[email protected]>
Co-authored-by: Brandon Kraft <[email protected]>
@jeherve jeherve mentioned this issue Jun 7, 2022
Closed
@jeherve jeherve mentioned this issue Aug 9, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
Epic Formerly "Primary Issue", or "Master Issue" General [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Janitorial
Projects
None yet
Milestone
jetpack/10.9.1
Development

No branches or pull requests
2 participants
@kraftbj @jeherve