Add Google Fonts provider and register a selection of fonts

[creativecoder]

Changes proposed in this Pull Request:

• Adds a new Jetpack package with a font provider for Google fonts, based on the work from Webfonts API - webfonts collection implementation WordPress/wordpress-develop#1736, and using the Simplified API from Webfonts API WordPress/gutenberg#37140.
• Adds a Jetpack plugin module that registers a selection of Google Fonts from the Jetpack Global Styles feature (https://github.com/Automattic/wp-calypso/blob/3fff686fba8d74690cd03ec5f10ac43ec3e046b3/apps/editing-toolkit/editing-toolkit-plugin/global-styles/class-global-styles.php#L84)

Jetpack product discussion

paYE8P-1qo-p2

Does this pull request change what data or activity we track or use?

Loads Google Fonts settings and font files using Google APIs, if the module is activated.

Testing instructions:

Install the Gutenberg plugin with changes from this PR WordPress/gutenberg#37140 (now in Gutenberg trunk, but not yet released).

• pnpm jetpack install -r && pnpm jetpack install --all to install the new fonts provider package.
• Activate the Jetpack plugin and activate the Google Fonts module from /wp-admin/admin.php?page=jetpack_modules
• Activate a block based theme, such as Twenty Twenty Two
• Go to the Site editor and open the Global Styles > Text panel and select one of the new font choices.

• Save your changes and check that the font loads on the front end of the Site.
• Open the Post editor and add a block that has font styles, like a button block.
• Select one of the font options, save, and check the front-end.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ⚠️ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

---

Jetpack plugin:

• Next scheduled release: April 5, 2022.
• Scheduled code freeze: March 29, 2022.

[creativecoder]

wpcom diff: D75501-code

[jeherve]

Just made a few general comments. I think we could merge this early on and iterate later on, if you'd like to test this further.

[jeherve]

I don't know that I would auto-activate the module until we have a UI for it in the Jetpack > Dashboard, so folks can disable the feature if they'd like it.

[creativecoder]

Changed to No. Do you know how we could auto-activate it only on Atomic sites?

Let me know if there are any other module header changes you would recommend. I wasn't sure how to set things like recommendation order.

[jeherve]

There are different ways we could go about it, depending on how you'd like to approach the deployment of this feature. Here is what comes to mind:

• If you'd rather not offer any UI, and enable it on all WoA sites right away, we could get rid of this module file in Jetpack, and instead require and instantiate the package from wpcomsh. This is what we do for the post-list package for example; the package isn't used in the Jetpack plugin, but is used in the wpcomsh plugin.
• If you'd like to offer a basic UI (in the legacy full module list) that would eventually turn into a proper setting in the Jetpack dashboard once the feature is deemed ready, you could enable the module on WoA like we do for the masterbar feature in wpcomsh. Check the feature-plugins directory for an example.

[creativecoder]

I think it'd be nice to have a minimal UI for the module in Jetpack. I imagine lot's of plugin users will be interested in this feature, outside of WP.com hosted sites.

If you're willing, I'd like to get this basic version merged without a UI, and follow up with auto-activating the module for Atomic sites (wpcomsh) and adding a basic UI (Jetpack).

[jeherve]

That works for me!

[jeherve]

Install the Gutenberg plugin with changes in this PR WordPress/gutenberg#37140

Noting that the PR has now been merged.

[creativecoder]

@jeherve While the Google Fonts module doesn't require a Jetpack connection to work, do we need to put ithe module behind a connection to make sure users have agreed to Jetpack's terms, first? Loading Google fonts from a site does have some privacy implications for visitors to the site.

[jeherve]

That's a good question. I think those privacy implications may be between Google and the site owner, I'm not sure that's something we can cover in our own terms? That may be a better question to ask in +automattlock maybe?

[creativecoder]

Noting that D75501-code (for wpcom testing) is now updated with the latest module and provider changes from this PR.

[jeherve]

This tests well for me. Let's merge this, and iterate with a UI and maybe changes to address any legal requirements as we discussed.

[jeherve]

I've created a draft support doc we can update once we have some more information about the feature and its activation, and I've created #23295 to add a toggle to the Jetpack dashboard to turn the feature on and off.