Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Styles: Add support for google fonts in the site editor WIP #20674

Closed

Conversation

jeyip
Copy link
Contributor

@jeyip jeyip commented Aug 12, 2021

Team Cylon is working on releasing Full Site Editing (currently found in the Gutenburg plugin) as an opt-in beta feature on WordPress.com. One of the features we plan to include is enabling the selection of Google fonts within the Global Styles settings found in the Site Editor, rather than only the default font choices. ( link )

Note that at the moment, you can only access Gutenberg’s Global Styles from the Site Editor, which only appears in wp-admin when using a block-based theme.

2021-08-10 14 13 26

Fixes #

Changes proposed in this Pull Request:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeyip! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D65456-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jeyip jeyip changed the title WIP Global Styles: Add support for google fonts in the site editor WIP Aug 12, 2021
@jeyip jeyip marked this pull request as draft August 12, 2021 20:08
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Aug 12, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: September 7, 2021.
  • Scheduled code freeze: August 30, 2021.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 12, 2021
@jeyip jeyip self-assigned this Aug 13, 2021
@jeherve
Copy link
Member

jeherve commented Mar 2, 2022

Closing this in favor of #23045

@jeherve jeherve closed this Mar 2, 2022
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Mar 2, 2022
@jeyip jeyip deleted the add/site-editor-google-fonts-support-in-extensions branch April 24, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants