Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit: Run eslint --fix like we do phpcbf #21923

Merged
merged 1 commit into from
Dec 1, 2021
Merged

pre-commit: Run eslint --fix like we do phpcbf #21923

merged 1 commit into from
Dec 1, 2021

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Dec 1, 2021

Changes proposed in this Pull Request:

Said someone in Slack:

Whenever I commit:
ESLint: we fixed a few hundred formatting issues, refactored everything, and fixed a couple of bugs.
Also ESLint: Invalid JSDoc @param type "function"; prefer: "Function"

The first bit was actually prettier, not eslint. But it should also be
eslint, so let's make that happen.

Jetpack product discussion

p1638369236025800-slack-G78B6FYE7

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Try adding some fixable eslint things to non-excluded files, then try committing them.

@anomiex
pre-commit: Run eslint --fix like we do phpcbf
8da5144 
Said someone in Slack:

> Whenever I commit:
> ESLint: we fixed a few hundred formatting issues, refactored everything, and fixed a couple of bugs.
> Also ESLint: `Invalid JSDoc @param type "function"; prefer: "Function"`

The first bit was actually prettier, not eslint. But it should also be
eslint, so let's make that happen.
@anomiex anomiex added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal labels Dec 1, 2021
@anomiex anomiex self-assigned this Dec 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@anomiex anomiex enabled auto-merge (squash) December 1, 2021 15:33
kraftbj
kraftbj approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@anomiex anomiex merged commit c006d96 into master Dec 1, 2021
@anomiex anomiex deleted the add/pre-commit-eslint-fix branch December 1, 2021 21:05
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Dec 1, 2021
davidlonjon added a commit that referenced this pull request Dec 2, 2021
@davidlonjon
Merge branch 'master' into add/boost-e2e-tests
9d22935 
* master:
  Added a custom composer installer to use a separate vendor folder. (#21877)
  Masterbar: rewrite tracks-events.js without jQuery (#21907)
  pre-commit: Run `eslint --fix` like we do `phpcbf` (#21923)
  Hide licenses activation route when user account not linked. (#21919)
  Beta: Handle exception when no Internet connection (#21915)
  Update wordpress monorepo (#21918)
  Pin dependency automattic/wordbless to 0.3.1 (#21920)
  Use new GitHub secret to manage pushing to Project Boards (#21838)
  Backup: provide additional disconnect info in backup plugin (#21421)
  IDC: Event tracking for the new screen (#21900)
  Releases: add testing list for Jetpack 10.4 (#21909)
  Jetpack 10.5-a.0 Cycle Start (#21912)
  Jetpack 10.4: Changelog (#21908)
  Add/contextualized jetpack connection (#21815)
  Fix masterbar not being displayed entirely for resolutions of under 660px. (#21871)
  Handle the intermittent occurrence of null in `columnWidths[ rowIndex ]` array  in TiledGallery (#21892)
  Add to My Plan's header section a small licensing-related piece of copy (#21899)
  Sharing: ask search engines to not index pages with query string. (#21843)
  PR Template: Indicate use of milestone (#21898)
  Likes: add some extra checks to queuehandler.js (#21896)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

Assignees

@anomiex anomiex

Labels
[Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anomiex @kraftbj