Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup: provide additional disconnect info in backup plugin #21421

Merged
merged 109 commits into from
Nov 30, 2021
Merged

Backup: provide additional disconnect info in backup plugin #21421

merged 109 commits into from
Nov 30, 2021

Conversation

jboland88
Copy link
Contributor

@jboland88 jboland88 commented Oct 14, 2021 •
edited
Loading

This PR is related to and based from #21048

Changes proposed in this Pull Request:

  • Include data about other plugins using the Jetpack connection in the initial state for the Jetpack Backups app.
  • Include analytics scripts for the <DisconnectDialog />.

Jetpack product discussion

pbNhbs-V4-p2

Does this pull request change what data or activity we track or use?

This PR does not track any new data or activity on its own.

Testing instructions:

  • Review PR Jetpack: Extend disconnection dialog component to handle multiple steps and accept more props #21048 to get an overview of the updates to the disconnect dialog component that this PR uses.

  • On your development Jetpack environment, make sure you have the Jetpack Backup plugin installed and activated.

  • Make sure you also have at least one other plugin that uses the Jetpack connection installed and active ( Boost, Jetpack )

  • Go to the Jetpack Backup admin screen.

  • If not already connected, follow the connection flow to connect the Jetpack site.

  • Once connected, from the Jetpack Backup admin page, click the "Disconnect" link in the connection area.

  • This will open the Disconnect Dialog.

  • You should see a list of other connected plugins presented in the first screen that looks like the example below:
    Screen Shot 2021-10-14 at 12 13 42 PM

  • After a successful disconnect, you will see the disconnect confirmation screen, which will provide the option to give some feedback. You can also exit the flow here by clicking on "No thank you"
    Screen Shot 2021-10-22 at 3 55 35 PM

  • Click on the "Help us improve" button to go to the survey screen.
    Screen Shot 2021-10-14 at 12 05 25 PM

  • On the survey screen, the "Submit Feedback" button should be disabled until a response is selected. Selecting a response should show the response in an active/ selected state that looks like this:
    Screen Shot 2021-10-14 at 12 05 37 PM

  • Press "Submit Feedback" to submit the response and move to the last step. ( note, the disconnect flow can be exited here without providing feedback by clicking on "Skip for now" )

  • The survey response is sent to a WPCOM endpoint. Observe your network panel traffic for a POST request to a feedback-survey endpoint. You should receive a 200 response from this endpoint.

  • The final step of the flow is the "Thank You" screen. You can click "Back to my website," which will exit the disconnect flow and call the passed onDisconnect prop - if provided.
    Screen Shot 2021-11-20 at 11 25 49 AM

  • Check that the analytics events from the test plan for Jetpack: Extend disconnection dialog component to handle multiple steps and accept more props #21048 are recorded by tracks.

  • After exiting the disconnect flow, you should see the Connect screen for the backups plugin:
    Screen Shot 2021-10-22 at 5 29 50 PM

@jboland88 jboland88 mentioned this pull request Oct 14, 2021
Merged
@github-actions github-actions bot added the [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. label Oct 20, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: December 7, 2021.
  • Scheduled code freeze: November 30, 2021.

Backup plugin:

  • Next scheduled release: December 7, 2021.
  • Scheduled code freeze: November 29, 2021.

Boost plugin:

  • Next scheduled release: December 7, 2021.
  • Scheduled code freeze: November 29, 2021.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 20, 2021
@jboland88 jboland88 force-pushed the update/provide-additional-disconnect-info-in-backup-plugin branch from ea4ac4e to 034324e Compare October 22, 2021 21:16
@jboland88 jboland88 marked this pull request as ready for review October 22, 2021 21:54
@jeherve jeherve changed the title Update/provide additional disconnect info in backup plugin Backup: provide additional disconnect info in backup plugin Oct 25, 2021
@jeherve jeherve added this to the backup/1.1.0 milestone Oct 25, 2021
@github-actions github-actions bot added [JS Package] Connection [JS Package] Components [JS Package] IDC [JS Package] Licensing [JS Package] Storybook [Package] Connection UI This package no longer exists in the monorepo. [Package] My Jetpack [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Boost A feature to speed up the site and improve performance. labels Nov 29, 2021
@jboland88 jboland88 added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Nov 30, 2021
@jboland88 jboland88 requested a review from samiff November 30, 2021 14:55
@jboland88 jboland88 removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 30, 2021
@jboland88
Copy link
Contributor Author

@samiff - previous review was marked as stale after the original base branch for this PR was merged.
I've done some cleanup and have things updated now. There were not any substantial changes to the code here, so hopefully should be a quick re-review :)

@samiff samiff enabled auto-merge (squash) November 30, 2021 22:59
@samiff samiff added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 30, 2021
@samiff samiff merged commit fe13f8e into master Nov 30, 2021
@samiff samiff deleted the update/provide-additional-disconnect-info-in-backup-plugin branch November 30, 2021 23:23
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 30, 2021
davidlonjon added a commit that referenced this pull request Dec 2, 2021
@davidlonjon
Merge branch 'master' into add/boost-e2e-tests
9d22935 
* master:
  Added a custom composer installer to use a separate vendor folder. (#21877)
  Masterbar: rewrite tracks-events.js without jQuery (#21907)
  pre-commit: Run `eslint --fix` like we do `phpcbf` (#21923)
  Hide licenses activation route when user account not linked. (#21919)
  Beta: Handle exception when no Internet connection (#21915)
  Update wordpress monorepo (#21918)
  Pin dependency automattic/wordbless to 0.3.1 (#21920)
  Use new GitHub secret to manage pushing to Project Boards (#21838)
  Backup: provide additional disconnect info in backup plugin (#21421)
  IDC: Event tracking for the new screen (#21900)
  Releases: add testing list for Jetpack 10.4 (#21909)
  Jetpack 10.5-a.0 Cycle Start (#21912)
  Jetpack 10.4: Changelog (#21908)
  Add/contextualized jetpack connection (#21815)
  Fix masterbar not being displayed entirely for resolutions of under 660px. (#21871)
  Handle the intermittent occurrence of null in `columnWidths[ rowIndex ]` array  in TiledGallery (#21892)
  Add to My Plan's header section a small licensing-related piece of copy (#21899)
  Sharing: ask search engines to not index pages with query string. (#21843)
  PR Template: Indicate use of milestone (#21898)
  Likes: add some extra checks to queuehandler.js (#21896)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samiff samiff samiff approved these changes

@travisw travisw travisw left review comments

@fgiannar fgiannar Awaiting requested review from fgiannar

@leogermani leogermani Awaiting requested review from leogermani

@IanRamosC IanRamosC Awaiting requested review from IanRamosC

Assignees

@jboland88 jboland88

Labels
Admin Page React-powered dashboard under the Jetpack menu [JS Package] API [JS Package] Components [JS Package] Connection [JS Package] IDC [JS Package] Licensing [JS Package] Storybook [Package] Connection UI This package no longer exists in the monorepo. [Package] My Jetpack [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA
Projects
None yet
Milestone
backup/1.1.0
Development

Successfully merging this pull request may close these issues.
8 participants
@jboland88 @kraftbj @travisw @leogermani @samiff @jeherve @matticbot @IanRamosC