Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assets: do not use the new method yet #21760

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Assets: do not use the new method yet #21760

merged 1 commit into from
Nov 16, 2021

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Nov 16, 2021 •
edited
Loading

This reverts part of #21689

Changes proposed in this Pull Request:

Given the issues that were raised post merge on WordPress.com, let's refrain from using the new method just yet.

On WordPress.com, this was already reverted in D70135-code.

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Does everything get reverted properly?

@jeherve jeherve requested a review from a team as a code owner November 16, 2021 14:20
@jeherve jeherve added this to the jetpack/10.4 milestone Nov 16, 2021
@jeherve jeherve added [Pri] BLOCKER [Status] In Progress [Type] Bug When a feature is broken and / or not performing as intended labels Nov 16, 2021
@jeherve jeherve self-assigned this Nov 16, 2021
@github-actions github-actions bot added [Package] Assets [Package] Connection UI This package no longer exists in the monorepo. [Package] Jitm [Package] Lazy Images This package no longer exists in the monorepo. [Package] Post List [Package] Tracking This package no longer exists in the monorepo. It was merged into [Package] Connection. [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Feature] Search For all things related to Search [Feature] Widget Visibility labels Nov 16, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: December 7, 2021.
  • Scheduled code freeze: November 30, 2021.

Backup plugin:

  • Next scheduled release: December 7, 2021.
  • Scheduled code freeze: November 29, 2021.

Boost plugin:

  • Next scheduled release: November 30, 2021.
  • Scheduled code freeze: November 23, 2021.

@jeherve jeherve force-pushed the revert/assets-change branch 5 times, most recently from ea572d6 to 9df2113 Compare November 16, 2021 14:40
@jeherve
Assets: do not use the new method yet
e185b14 
This reverts part of #21689

Given the issues that were raised post merge on WordPress.com, let's refrain from using the new method just yet.
@jeherve jeherve force-pushed the revert/assets-change branch from 9df2113 to e185b14 Compare November 16, 2021 14:49
@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Nov 16, 2021
sdixon194
sdixon194 approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@sdixon194 sdixon194 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all works for me. I know there's ongoing discussion, but approving now to unblock Atomic release.

@sdixon194 sdixon194 removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Nov 16, 2021
@sdixon194 sdixon194 added the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 16, 2021
@sdixon194 sdixon194 mentioned this pull request Nov 16, 2021
Merged
@jeherve jeherve merged commit bc3075a into master Nov 16, 2021
@jeherve jeherve deleted the revert/assets-change branch November 16, 2021 15:52
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 16, 2021
@sdixon194 sdixon194 mentioned this pull request Nov 16, 2021
Merged
anomiex added a commit that referenced this pull request Nov 16, 2021
@anomiex
Revert "Assets: do not use the new method yet (#21760)"
d23e52c 
This reverts commit bc3075a.
@anomiex anomiex mentioned this pull request Nov 16, 2021
Merged
anomiex added a commit that referenced this pull request Nov 16, 2021
@anomiex
Revert and fix "Revert "Assets: do not use the new method yet (#21760)…
633301e 
…"" (#21763)

The new `Assets::register_script` wrapper worked great. In fact, a bit
too good: it picked up a style dependency that was missing from the
editor JS, which broke the Widget Editor and the Site Editor because
that dependency is specifically not supposed to be loaded there
(see #20357).

This reverts #21760 and adds a hack around the way that #20357 made
things break with the new wrapper.
davidlonjon added a commit that referenced this pull request Nov 18, 2021
@davidlonjon
Merge branch 'master' into add/boost-e2e-workflow-dependencies-trigger
e38730f 
* master: (28 commits)
  Prepare for 10.4-a.7 (#21797)
  Check if maxwidth exists before trying to call .length (#21785)
  Podcast Player: Increase podcast shown (#21661)
  licensing: jetpack-js-test-runner is a dev dependency (#21794)
  Update dependency @mdn/browser-compat-data to v4.0.11 (#21792)
  Tests: Fix unit tests for wpcom (#21649)
  SSO: Fix Button Text Alignment on Mobile   (#18770)
  Add/my jetpack skeleton (#21464)
  Identity Crisis: add unit tests for has_identity_crisis and get_mismatched_urls (#21754)
  Remove special cases for calling changelogger on packages/changelogger (#21783)
  eslint-config-target-es: Release 1.0.0! (#21766)
  Revert "WPCOM no longer forces home_urls to be http" (#21769)
  WPCOM no longer forces home_urls to be http (#21747)
  Revert and fix "Revert "Assets: do not use the new method yet (#21760)"" (#21763)
  eslint-config-target-es: Fix README.md (#21743)
  codesniffer: Disable CI on PHP 8.1 (#21742)
  RNA Pricing card component: Fix case where prices before and after match (#21757)
  Janitorial: update Jetpack version for 10.4-a.6 cycle (#21762)
  Releases: prepare changelog for 10.4-a.5 release (#21758)
  Assets: do not use the new method yet (#21760)
  ...
davidlonjon added a commit that referenced this pull request Nov 19, 2021
@davidlonjon
Merge branch 'master' into add/boost-e2e-tests
b75b876 
* master: (28 commits)
  Prepare for 10.4-a.7 (#21797)
  Check if maxwidth exists before trying to call .length (#21785)
  Podcast Player: Increase podcast shown (#21661)
  licensing: jetpack-js-test-runner is a dev dependency (#21794)
  Update dependency @mdn/browser-compat-data to v4.0.11 (#21792)
  Tests: Fix unit tests for wpcom (#21649)
  SSO: Fix Button Text Alignment on Mobile   (#18770)
  Add/my jetpack skeleton (#21464)
  Identity Crisis: add unit tests for has_identity_crisis and get_mismatched_urls (#21754)
  Remove special cases for calling changelogger on packages/changelogger (#21783)
  eslint-config-target-es: Release 1.0.0! (#21766)
  Revert "WPCOM no longer forces home_urls to be http" (#21769)
  WPCOM no longer forces home_urls to be http (#21747)
  Revert and fix "Revert "Assets: do not use the new method yet (#21760)"" (#21763)
  eslint-config-target-es: Fix README.md (#21743)
  codesniffer: Disable CI on PHP 8.1 (#21742)
  RNA Pricing card component: Fix case where prices before and after match (#21757)
  Janitorial: update Jetpack version for 10.4-a.6 cycle (#21762)
  Releases: prepare changelog for 10.4-a.5 release (#21758)
  Assets: do not use the new method yet (#21760)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdixon194 sdixon194 sdixon194 approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Search For all things related to Search [Feature] Widget Visibility [Package] Assets [Package] Connection UI This package no longer exists in the monorepo. [Package] Jitm [Package] Lazy Images This package no longer exists in the monorepo. [Package] Post List [Package] Tracking This package no longer exists in the monorepo. It was merged into [Package] Connection. [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] BLOCKER Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
jetpack/10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jeherve @sdixon194 @matticbot