My Jetpack: Add initial skeleton #21464

leogermani · 2021-10-20T01:07:14Z

This PR bootstraps the My Jetpack package, including a React app that will hold the whole My Jetpack page on admin.

For now, it's a very simple skeleton. Header and Footer are there as placeholders as we still need to work on these generic components and shared CSS styles.

Changes proposed in this Pull Request:

Adds the skeleton of the My Jetpack package and JS app

Jetpack product discussion

p9dueE-3Ae-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Make sure Jetpack and my-jetpack package are built
Add define( 'JETPACK_ENABLE_MY_JETPACK', true ); to your wp-config.php
Make sure there's a My Jetpack submenu under the Jetpack top-level menu
Look at the code organization and give feedback - it was mostly copied from the connection-ui package

github-actions · 2021-10-20T01:08:23Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
⚠️ All commits were linted before commit.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

Next scheduled release: December 7, 2021.
Scheduled code freeze: November 30, 2021.

matticbot · 2021-10-20T19:50:29Z

Caution: This PR has changes that must be merged to WordPress.com
Hello leogermani! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D68780-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

projects/packages/my-jetpack/gulpfile.babel.js

projects/packages/my-jetpack/phpunit.xml.dist

anomiex · 2021-10-27T14:21:22Z

projects/packages/my-jetpack/composer.json

+		"build-production": "echo 'Add your build step to composer.json, please!'",
+		"build-development": "echo 'Add your build step to composer.json, please!'"


Looks like you still need to add the build rules.

Co-authored-by: Brad Jorsch <[email protected]>

anomiex · 2021-11-16T18:17:56Z

projects/packages/my-jetpack/src/class-initializer.php

+		$build_assets = require_once __DIR__ . '/../build/index.asset.php';
+		wp_enqueue_script( 'my_jetpack_main_app', plugin_dir_url( __DIR__ ) . 'build/index.js', $build_assets['dependencies'], $build_assets['version'], true );


We should use Assets::register_script() here. That should automatically handle adding the CSS too once it gets created.

projects/packages/my-jetpack/README.md

samiff · 2021-11-16T20:22:04Z

projects/packages/my-jetpack/src/class-initializer.php

+	 *
+	 * @var boolean
+	 */
+	private static $initialized = false;


Maybe we could use an action to only init once? It's something I try to keep in mind that was mentioned to me here.

I've seen both patterns and I usually prefer the static property, just because it's much more performant. I can see some advantages that @zinigor points out, but at the end of the day it's all theoretical, not sure we ever used these actions for anything else... Let me think this over... If anyone has strong opinions on that let me know. Not a big deal to me

not sure we ever used these actions for anything else

It just came to mind since we will be requiring all Jetpack plugins to add this. Exactly what/why someone might hook into that for? 🤷 but it sounds good in theory 😃

ok, changed to the hooks approach, I could argue on the cons of this approach, or why it's not effective (we should add two hooks, one before and one after initialization, and offer a way for people to short circuit the initialization if we wanted this to be really useful).

But I like how explicit it is about what's going on, and easier to test

sergeymitr

Great job! 🚢

github-actions · 2021-11-17T17:03:21Z

Great news! One last step: head over to your WordPress.com diff, D68780-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

kraftbj · 2021-11-18T02:05:40Z

Just wanted to note b/c of our naming structure, this becomes the automattic/jetpack-my-jetpack package.

This reverts commit b90e57f.

* master: (28 commits) Prepare for 10.4-a.7 (#21797) Check if maxwidth exists before trying to call .length (#21785) Podcast Player: Increase podcast shown (#21661) licensing: jetpack-js-test-runner is a dev dependency (#21794) Update dependency @mdn/browser-compat-data to v4.0.11 (#21792) Tests: Fix unit tests for wpcom (#21649) SSO: Fix Button Text Alignment on Mobile (#18770) Add/my jetpack skeleton (#21464) Identity Crisis: add unit tests for has_identity_crisis and get_mismatched_urls (#21754) Remove special cases for calling changelogger on packages/changelogger (#21783) eslint-config-target-es: Release 1.0.0! (#21766) Revert "WPCOM no longer forces home_urls to be http" (#21769) WPCOM no longer forces home_urls to be http (#21747) Revert and fix "Revert "Assets: do not use the new method yet (#21760)"" (#21763) eslint-config-target-es: Fix README.md (#21743) codesniffer: Disable CI on PHP 8.1 (#21742) RNA Pricing card component: Fix case where prices before and after match (#21757) Janitorial: update Jetpack version for 10.4-a.6 cycle (#21762) Releases: prepare changelog for 10.4-a.5 release (#21758) Assets: do not use the new method yet (#21760) ...

anomiex · 2021-11-18T15:14:35Z

Just wanted to note b/c of our naming structure, this becomes the automattic/jetpack-my-jetpack package.

It doesn't have to if we don't want it to, that's just the default. We could change the name in composer.json (and maybe a few other places) if we want it to be something different.

anomiex · 2021-11-18T17:10:05Z

r235273-wpcom

* master: (28 commits) Prepare for 10.4-a.7 (#21797) Check if maxwidth exists before trying to call .length (#21785) Podcast Player: Increase podcast shown (#21661) licensing: jetpack-js-test-runner is a dev dependency (#21794) Update dependency @mdn/browser-compat-data to v4.0.11 (#21792) Tests: Fix unit tests for wpcom (#21649) SSO: Fix Button Text Alignment on Mobile (#18770) Add/my jetpack skeleton (#21464) Identity Crisis: add unit tests for has_identity_crisis and get_mismatched_urls (#21754) Remove special cases for calling changelogger on packages/changelogger (#21783) eslint-config-target-es: Release 1.0.0! (#21766) Revert "WPCOM no longer forces home_urls to be http" (#21769) WPCOM no longer forces home_urls to be http (#21747) Revert and fix "Revert "Assets: do not use the new method yet (#21760)"" (#21763) eslint-config-target-es: Fix README.md (#21743) codesniffer: Disable CI on PHP 8.1 (#21742) RNA Pricing card component: Fix case where prices before and after match (#21757) Janitorial: update Jetpack version for 10.4-a.6 cycle (#21762) Releases: prepare changelog for 10.4-a.5 release (#21758) Assets: do not use the new method yet (#21760) ...

leogermani added 2 commits October 19, 2021 22:00

adds new composer package

aa3ce49

initialize My Jetpack

9362f9b

github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Package] My Jetpack labels Oct 20, 2021

github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 20, 2021

leogermani added 3 commits October 20, 2021 16:37

bootstrap the JS My Jetpack app

832412d

add my-jetpack to renovate ignore list

fbfa303

add changelog

55fe1e7

matticbot added the Touches WP.com Files label Oct 20, 2021

leogermani marked this pull request as ready for review October 20, 2021 19:50

leogermani added 2 commits October 20, 2021 17:00

Merge branch 'master' into add/my-jetpack-skeleton

ce70e15

updating internal dependencies and lock files

bd510e9

leogermani added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Oct 20, 2021

leogermani requested a review from sergeymitr October 25, 2021 16:39

anomiex reviewed Oct 27, 2021

View reviewed changes

anomiex added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 27, 2021

anomiex mentioned this pull request Oct 27, 2021

cli: Fix skeleton phpunit config #21555

Merged

leogermani and others added 7 commits October 27, 2021 11:31

Update projects/packages/my-jetpack/phpunit.xml.dist

6983e96

Co-authored-by: Brad Jorsch <[email protected]>

Update projects/packages/my-jetpack/phpunit.xml.dist

f98646f

Co-authored-by: Brad Jorsch <[email protected]>

remove gulp dependency

7616186

add build scripts to composer.json

7c6f79b

[not verified] Merge branch 'master' into add/my-jetpack-skeleton

d73c060

update composer lock

cabd23e

fix dependencies

1695f01

leogermani added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Nov 8, 2021

update lock file

9927a61

anomiex reviewed Nov 16, 2021

View reviewed changes

sergeymitr added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 16, 2021

samiff reviewed Nov 16, 2021

View reviewed changes

projects/packages/my-jetpack/README.md Outdated Show resolved Hide resolved

samiff reviewed Nov 16, 2021

View reviewed changes

leogermani and others added 8 commits November 16, 2021 18:00

Use Assets to register script

da2635f

update lock file

a5cd402

update README

0972e3f

Fix typo

66c45eb

replace static property with action hook

4d96f90

Merge branch 'master' into add/my-jetpack-skeleton

9693452

update dependecies

268b48e

Refresh PNPM lock file.

f297eff

sergeymitr approved these changes Nov 17, 2021

View reviewed changes

sergeymitr added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Nov 17, 2021

leogermani merged commit b90e57f into master Nov 17, 2021

leogermani deleted the add/my-jetpack-skeleton branch November 17, 2021 17:02

github-actions bot added this to the jetpack/10.4 milestone Nov 17, 2021

github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 17, 2021

kraftbj added a commit that referenced this pull request Nov 18, 2021

Revert "Add/my jetpack skeleton (#21464)"

2af5960

This reverts commit b90e57f.

oskosk changed the title ~~Add/my jetpack skeleton~~ My Jetpack: Add initial skeleton Jan 10, 2022

oskosk mentioned this pull request Jan 10, 2022

My Jetpack MVP: Overview #22285

Closed

47 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

My Jetpack: Add initial skeleton #21464

My Jetpack: Add initial skeleton #21464

leogermani commented Oct 20, 2021 •

edited

Loading

github-actions bot commented Oct 20, 2021 •

edited

Loading

matticbot commented Oct 20, 2021

anomiex Oct 27, 2021

leogermani Nov 8, 2021

anomiex Nov 16, 2021

samiff Nov 16, 2021

leogermani Nov 16, 2021

samiff Nov 16, 2021

leogermani Nov 17, 2021

sergeymitr left a comment

github-actions bot commented Nov 17, 2021

kraftbj commented Nov 18, 2021

anomiex commented Nov 18, 2021

anomiex commented Nov 18, 2021

		"build-production": "echo 'Add your build step to composer.json, please!'",
		"build-development": "echo 'Add your build step to composer.json, please!'"

		$build_assets = require_once __DIR__ . '/../build/index.asset.php';
		wp_enqueue_script( 'my_jetpack_main_app', plugin_dir_url( __DIR__ ) . 'build/index.js', $build_assets['dependencies'], $build_assets['version'], true );

My Jetpack: Add initial skeleton #21464

My Jetpack: Add initial skeleton #21464

Conversation

leogermani commented Oct 20, 2021 • edited Loading

Changes proposed in this Pull Request:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Oct 20, 2021 • edited Loading

matticbot commented Oct 20, 2021

anomiex Oct 27, 2021

Choose a reason for hiding this comment

leogermani Nov 8, 2021

Choose a reason for hiding this comment

anomiex Nov 16, 2021

Choose a reason for hiding this comment

samiff Nov 16, 2021

Choose a reason for hiding this comment

leogermani Nov 16, 2021

Choose a reason for hiding this comment

samiff Nov 16, 2021

Choose a reason for hiding this comment

leogermani Nov 17, 2021

Choose a reason for hiding this comment

sergeymitr left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 17, 2021

kraftbj commented Nov 18, 2021

anomiex commented Nov 18, 2021

anomiex commented Nov 18, 2021

leogermani commented Oct 20, 2021 •

edited

Loading

github-actions bot commented Oct 20, 2021 •

edited

Loading