Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTable Block: Make sure the placeholder is a block element #14985

Merged
merged 1 commit into from
Mar 19, 2020
Merged

OpenTable Block: Make sure the placeholder is a block element #14985

merged 1 commit into from
Mar 19, 2020

Conversation

Copons
Copy link
Contributor

@Copons Copons commented Mar 13, 2020

Fixes #14976

Changes proposed in this Pull Request:

  • Make sure the placeholder of the OpenTable block is a display: block element.
Before After
Screenshot 2020-03-13 at 15 54 37 Screenshot 2020-03-13 at 15 54 18

Props to @simison for reporting this!

Testing instructions:

  • On Gutenberg 7.7, insert an OpenTable block.
  • Without embedding anything, try setting it to wide or full width.
  • Make sure the placeholder fills the entire space available.
  • Embed something and set the embed style to Wide.
  • Make sure the embedded widget fills the entire space available.

Proposed changelog entry for your changes:

  • Fix OpenTable block placeholder when in wide or full width.

@Copons Copons added [Type] Bug When a feature is broken and / or not performing as intended [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] OpenTable [Status] Needs Team Review labels Mar 13, 2020
@Copons Copons requested a review from a team March 13, 2020 16:00
@Copons Copons requested a review from a team as a code owner March 13, 2020 16:00
@Copons Copons self-assigned this Mar 13, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello Copons! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D40324-code before merging this PR. Thank you!

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against 92d54be

jeherve
jeherve approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 🚢

@jeherve jeherve added this to the 8.4 milestone Mar 19, 2020
@Copons Copons merged commit 59ca951 into master Mar 19, 2020
@Copons Copons deleted the fix/14976-open-table-placeholder-width branch March 19, 2020 16:57
@Copons
Copy link
Contributor Author

Copons commented Mar 19, 2020

r204528-wpcom

jeherve added a commit that referenced this pull request Mar 23, 2020
@jeherve
Changelog: add #14985
2cc1c8f
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
8.4 Changelog (#15075)
0eb0b35 
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@Copons Copons

Labels
[Block] OpenTable [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.4
Development

Successfully merging this pull request may close these issues.

Open table block: empty space on right
4 participants
@Copons @matticbot @jetpackbot @jeherve