Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contact widget error message style #13676

Merged
merged 3 commits into from
Mar 11, 2020
Merged

Fix contact widget error message style #13676

merged 3 commits into from
Mar 11, 2020

Conversation

wigglemuff
Copy link
Contributor

Changes proposed in this Pull Request:

Testing instructions:

  • Go to widget > add Contact Info & Map widget
  • Save without an API key
  • It returns an error but this fix makes it a little more visible (and hard to miss).

Screen Shot on 2019-10-05 at 07:19:57

Proposed changelog entry for your changes:

  • Fixes for error messages in "Contact Info & Map" widget.

@wigglemuff wigglemuff added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Extra Sidebar Widgets [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Low labels Oct 5, 2019
@wigglemuff wigglemuff requested a review from a team as a code owner October 5, 2019 16:53
@wigglemuff wigglemuff self-assigned this Oct 5, 2019
@jetpackbot
Copy link

jetpackbot commented Oct 5, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against f581f6f

@jeherve
Copy link
Member

jeherve commented Oct 7, 2019

See comment here:

Where does the red colour you have chosen come from? Is it a colour used in core already? It looks quite different to the Delete below it for example.

@jeherve jeherve added this to the 7.9 milestone Oct 7, 2019
@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Oct 7, 2019
@wigglemuff
Copy link
Contributor Author

Update: Replied to @scottsweb in the issue - #13361 (comment)

@wigglemuff wigglemuff added [Status] Needs Design Review Design has been added. Needs a review! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Oct 12, 2019
@jeherve jeherve removed this from the 7.9 milestone Oct 17, 2019
@stale
Copy link

stale bot commented Jan 15, 2020

This PR has been marked as stale. This happened because:

  • It has been inactive in the past 3 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this PR has clear testing instructions, is it up to date with master, and it is still valid. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Jan 15, 2020
@stale stale bot removed the [Status] Stale label Mar 7, 2020
@wigglemuff wigglemuff mentioned this pull request Mar 7, 2020
Closed
@wigglemuff
Copy link
Contributor Author

The latest commit has the changes suggested by Scott (i.e. correct color code/css-class for the error message).

Screen Shot 2020-03-07 at 15 12 37

@wigglemuff wigglemuff added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Design Review Design has been added. Needs a review! labels Mar 7, 2020
@wigglemuff
Copy link
Contributor Author

@jeherve @kraftbj This should be good to go in 8.4

@jeherve jeherve removed [Status] Blocked / Hold [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Mar 11, 2020
@jeherve jeherve added the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 11, 2020
@jeherve jeherve added this to the 8.4 milestone Mar 11, 2020
jeherve
jeherve approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. It should be good to go once the tests pass. Thank you!

@jeherve jeherve merged commit 8e83ba5 into master Mar 11, 2020
@jeherve jeherve deleted the fix/contact-widget-err-msg branch March 11, 2020 18:13
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 11, 2020
jeherve added a commit that referenced this pull request Mar 23, 2020
@jeherve
Changelog: add #13676
d36fbe0
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
8.4 Changelog (#15075)
0eb0b35 
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@wigglemuff wigglemuff

Labels
[Feature] Extra Sidebar Widgets [Pri] Low Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
8.4
Development

Successfully merging this pull request may close these issues.

Contact Info Widget: improve styles for error messages displayed for map
4 participants
@wigglemuff @jetpackbot @jeherve @matticbot