Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugger: Makes SELF test optional #14198

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Debugger: Makes SELF test optional #14198

merged 2 commits into from
Dec 11, 2019

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Dec 9, 2019

Fixes #12881

The SELF test is of an older method of Jetpack and will increasingly not yield useful information. Keeping the test, but only running it when intentionally set, for the time-being.

Changes proposed in this Pull Request:

  • Skips the SELF test by default.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • n/a

Testing instructions:

  • Visit Tools->Site Info and confirm no failures.

Proposed changelog entry for your changes:

  • Site Info: Improve the Jetpack testing suite to reduce false positives.

@kraftbj
Debugger: Do not run the SELF test by default.
f7e0414 
The SELF test is from the old days. The First Age of Jetpack Debugging.

It is more prone to errors as uses a different test base than the Second Age
so let's focus on only one.
@kraftbj
Fix misspelling
66a6aac
@kraftbj kraftbj added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it General Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". labels Dec 9, 2019
@kraftbj kraftbj added this to the 8.1 milestone Dec 9, 2019
@kraftbj kraftbj requested a review from a team as a code owner December 9, 2019 18:11
@kraftbj kraftbj self-assigned this Dec 9, 2019
@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 66a6aac

@kraftbj kraftbj added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Dec 9, 2019
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Dec 10, 2019
@kraftbj kraftbj merged commit cf6ebe1 into master Dec 11, 2019
@kraftbj kraftbj deleted the remove/self branch December 11, 2019 06:00
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Dec 11, 2019
@kraftbj kraftbj mentioned this pull request Jan 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@kraftbj kraftbj

Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". General [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
8.1
Development

Successfully merging this pull request may close these issues.

Debugger / Site Health Displaying False-Positive Errors
4 participants
@kraftbj @jetpackbot @jeherve @matticbot