Slideshows: arrows must point in the right direction for all lang #10163
Conversation
Fixes #7384 Explicitely adding a direction to the default css ensures that direction gets flipped in the automatically generated RTL version of the file.
jeherve
added
[Type] Bug
|
Caution: This PR has changes that must be merged to WordPress.com |
|
That's a great PR description, thank you so much for your effort! Generated by 🚫 dangerJS |
| @@ -99,6 +99,7 @@ body div.slideshow-window * img { | |||
| -webkit-transition: 300ms opacity ease-out; | |||
| -moz-transition: 300ms opacity ease-out; | |||
| transition: 300ms opacity ease-out; | |||
| direction: ltr; | |||
There was a problem hiding this comment.
Looks like direction was already here, in the line 98:
jetpack/modules/shortcodes/css/slideshow-shortcode.css
Lines 98 to 102 in 6c2f99c
There's /* @noflip */ just above this CSS class, does that have something to do with original issue?
There was a problem hiding this comment.
Oh heh, I need new glasses I guess.:) Thanks for taking a look!
There's /* @NoFlip */ just above this CSS class, does that have something to do with original issue?
That /* @noflip */ rule does not appear to be respected (direction gets flipped in the RTL file anyway), so that seems to be the culprit here indeed.
I pushed a new commit with the correct notation (/*rtl:ignore*/) for the library we use now, and it seems to work! I believe I got tricked by a cached file earlier.
|
Caution: This PR has changes that must be merged to WordPress.com |
kraftbj
added
[Status] Ready to Merge
ghost
removed
the
[Status] Ready to Merge
* Readme: add boilerplate for next release, 6.6 * Add 6.5 to the changelog.txt file * Set boilerplate testing list for 6.6 * Readme: update stable tag to 6.5 * Add bullets to 6.5 changelog items * Readme: add link to previous changelogs This will help folks who want to know more about past releases, while keeping the readme.txt short so as to not overwhelm translators and site owners only looking for information about the last release. * Changelog: add information at the top of the changelog file. * Changelog: add #10054 * Changelog: add #10078 * Changelog: add #10079 * Changelog: add #10064 * Changelog: add #10094 * Changelog: add #10096 * Testing list: add more information based on #10087 * Changelog: add #9847 * Changelog: add #10084 * Changelog: add #9918 * Changelog: add #7614 * Changelog: add #10116 * Changelog: add #10108 * Changelog: add #10041 * Changelog: add #10121 * Changelog: add #10134 * Changelog: add #10130 * Changelog: add #10109 * changelog: add #10137 * changelog: add #9952 * changelog: add #10120 * changelog: add #10162 * Changelog: add #10163 * Changelog: add #10092 * changelog: add #10156 * Changelog: add #10154 * changelog: add #10122 * Changelog: add #10101 * changelog: add #10105 * changelog: add #10190 * Changelog: add #10196 * changelog: add #10152 * Changelog: add #10153 * Testing list: add more details to Site Verification testing steps. @see #10143 (comment) * changelog: add #10194 * Changelog: add #10193
Fixes #7384
Changes proposed in this Pull Request:
Explicitly adding a direction to the default css ensures that direction gets flipped in the automatically generated RTL version of the file.
Testing instructions:
They should not look like this:
Note that the RTL file must be generated first, so you'll need to run
yarn build, and only after #10162 has been merged.Proposed changelog entry for your changes:
Slideshows: ensure arrows point in the right direction for RTL Languages.