Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcodes: ensure that we generate RTL & min files for slideshows #10162

Merged
merged 1 commit into from
Sep 20, 2018

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Sep 18, 2018

Changes proposed in this Pull Request:

Up until now, no rtl files or min files were generated when running yarn build.
This caused issues on RTL sites, but also in other places where we look for the file,
like in the work we are doing in #10102

Testing instructions:

Apply this branch, run yarn build, and check for 2 new minified files and an RTL file under modules/shortcodes/css/.

You can also check that the slideshows look good on a site using an RTL language.

Proposed changelog entry for your changes:

Shortcodes: ensure we build minified and RTL stylesheets for slideshows.

Up until now, no rtl files or min files were generated when running `yarn build`.
This caused issues on RTL sites, but also in other places where we look for the file,
like in the work we are doing in #10102
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Shortcodes / Embeds [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] i18n Internationalization / i18n, adaptation to different languages labels Sep 18, 2018
@jeherve jeherve added this to the 6.6 milestone Sep 18, 2018
@jeherve jeherve self-assigned this Sep 18, 2018
@jeherve jeherve requested a review from a team as a code owner September 18, 2018 15:36
@jetpackbot
Copy link

That's a great PR description, thank you so much for your effort!

Generated by 🚫 dangerJS

@georgestephanis
Copy link
Member

Yarp, especially as it's flagged to swap to the rtl version.

wp_style_add_data( 'jetpack-slideshow', 'rtl', 'replace' );

My guess is that it's heretofore been relying on wpcom side of the sync to manage the changes over. Better that we do it ourselves, methinks.

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 18, 2018
@jeherve jeherve merged commit a158ca3 into master Sep 20, 2018
@jeherve jeherve deleted the fix/slideshow-rtl-generation branch September 20, 2018 06:49
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 20, 2018
jeherve added a commit that referenced this pull request Sep 24, 2018
jeherve added a commit that referenced this pull request Sep 25, 2018
* Readme: add boilerplate for next release, 6.6

* Add 6.5 to the changelog.txt file

* Set boilerplate testing list for 6.6

* Readme: update stable tag to 6.5

* Add bullets to 6.5 changelog items

* Readme: add link to previous changelogs

This will help folks who want to know more about past releases,
while keeping the readme.txt short so as to not overwhelm translators and site owners only looking for information about the last release.

* Changelog: add information at the top of the changelog file.

* Changelog: add #10054

* Changelog: add #10078

* Changelog: add #10079

* Changelog: add #10064

* Changelog: add #10094

* Changelog: add #10096

* Testing list: add more information based on #10087

* Changelog: add #9847

* Changelog: add #10084

* Changelog: add #9918

* Changelog: add #7614

* Changelog: add #10116

* Changelog: add #10108

* Changelog: add #10041

* Changelog: add #10121

* Changelog: add #10134

* Changelog: add #10130

* Changelog: add #10109

* changelog: add #10137

* changelog: add #9952

* changelog: add #10120

* changelog: add #10162

* Changelog: add #10163

* Changelog: add #10092

* changelog: add #10156

* Changelog: add #10154

* changelog: add #10122

* Changelog: add #10101

* changelog: add #10105

* changelog: add #10190

* Changelog: add #10196

* changelog: add #10152

* Changelog: add #10153

* Testing list: add more details to Site Verification testing steps.

@see #10143 (comment)

* changelog: add #10194

* Changelog: add #10193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Shortcodes / Embeds [Focus] i18n Internationalization / i18n, adaptation to different languages [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants