Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tonesque: fix typo in function's comment. #10126

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Sep 11, 2018

Fixes #10124

Changes proposed in this Pull Request:

The color function accepts a type parameter that can be one of the following strings: hex, rgb, or hsv.

Testing instructions:

Not much to test here. You can check the get_color function downer in the same file, to see what types can be used.

Proposed changelog entry for your changes:

Tonesque: fix typo in function's comment.

Fixes #10124

The color function accepts a type parameter that can be one of the following strings: hex, rgb, or hsv.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Theme Tools [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 11, 2018
@jeherve jeherve self-assigned this Sep 11, 2018
@jeherve jeherve requested a review from a team as a code owner September 11, 2018 09:12
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Please review this diff before merging: D18128-code. (newly created revision)

@jeherve jeherve added this to the 6.6 milestone Sep 11, 2018
@jetpackbot
Copy link

That's a great PR description, thank you so much for your effort!

Generated by 🚫 dangerJS

Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 11, 2018
@jeherve jeherve merged commit 05ebb6c into master Sep 11, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 11, 2018
@jeherve jeherve deleted the fix/tonesque-comment-10124 branch September 11, 2018 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Theme Tools [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Tonesque Comment Error
4 participants