Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Tonesque Comment Error #10124

Closed
Kalus opened this issue Sep 10, 2018 · 1 comment · Fixed by #10126
Closed

Bug: Tonesque Comment Error #10124

Kalus opened this issue Sep 10, 2018 · 1 comment · Fixed by #10126
Assignees
@jeherve
Labels
[Feature] Theme Tools [Pri] Low [Type] Bug When a feature is broken and / or not performing as intended
Milestone
6.6

Comments

@Kalus
Copy link

Kalus commented Sep 10, 2018

Steps to reproduce the issue

  1. In jetpack/_inc/lib/tonesque.php, line 89.
  2. Tonesque has a comment saying it returns returns HSL. Should probably read as HSV?

What I expected

* @param optional $type (hex, rgb, hsv)

What happened instead

* @param optional $type (hex, rgb, hsl)
jeherve added a commit that referenced this issue Sep 11, 2018
@jeherve
Tonesque: fix typo in function's comment.
6f31bd7 
Fixes #10124

The color function accepts a type parameter that can be one of the following strings: hex, rgb, or hsv.
@jeherve jeherve self-assigned this Sep 11, 2018
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Theme Tools [Pri] Low labels Sep 11, 2018
@jeherve jeherve mentioned this issue Sep 11, 2018
Merged
@jeherve jeherve added this to the 6.6 milestone Sep 11, 2018
@jeherve
Copy link
Member

jeherve commented Sep 11, 2018

Yes, you're correct, that's a typo. We'll fix it in #10126

jeherve added a commit that referenced this issue Sep 11, 2018
@jeherve
Tonesque: fix typo in function's comment. (#10126)
05ebb6c 
Fixes #10124

#### Changes proposed in this Pull Request:

The color function accepts a type parameter that can be one of the following strings: hex, rgb, or hsv.


#### Testing instructions:

Not much to test here. You can check the `get_color` function downer in the same file, to see what types can be used.

<!-- Add the following only if this is meant to be in changelog -->
#### Proposed changelog entry for your changes:
Tonesque: fix typo in function's comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
[Feature] Theme Tools [Pri] Low [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
6.6
Development

Successfully merging a pull request may close this issue.

Tonesque: fix typo in function's comment. Automattic/jetpack
2 participants
@Kalus @jeherve