Build out list of all vanilla WordPress “blocks” and their AMP compatibility

[westonruter]

[Edited] Refer to the latest acceptance criteria.

---

We want to ensure that if you have AMP installed as the sole plugin in a WordPress install that everything you can do in a vanilla WordPress site is compatible with AMP: every embed that a user can add to a post, every inserted media, every widget added to a sidebar, and even the various template parts that WordPress outputs (e.g. wp_nav_menu(), get_search_form(), and comments_template()). This can be paired with Theme Unit Test sample data and validation checklists.

If we do this right, we can then incorporate the test data into the build process to make sure that we don't break AMP compatibility with anything WordPress does.

This will also need to be done for Gutenberg blocks.

[MackenzieHartung]

Acceptance Criteria

1. Anything that WordPress allows to be input into post content, regarding embeds, should be supported by AMP.
2. Generate a list of all embeds that exist within WordPress (out of the box experience).
3. Verify which of the embed types work in AMP, somewhat work in AMP, or do not work in AMP.

[ThierryA]

AMP Support

Update: this list is now updated, and located in the project wiki

Below is a list of the AMP support for WP Vanilla content

AMP Support	Status	Note
Caption	✅
Media Gallery	✅
Media Image	✅
Media Video playlist	❌
Media Audio playlist	❌
Media Video	✅
Media Audio	✅
Post Embed	🔸	See #809 for improvements.
Amazon Embed	✅
Animoto Video Embed	✅
Cloudup Image Embed	✅
Cloudup Video Embed	✅
CollegeHumor Video Embed	🔸	Partial support, video player appears but doesn't play
DailyMotion Video Embed	✅
Facebook Post Embed	✅
Facebook Video Embed	✅
Flickr Image Embed	✅
Flickr Video Embed	✅
Funny Or Die Video Embed	✅
Instagram Embed	✅
Issuu Embed	✅
Kickstarter Embed	✅
MeetUp Embed	🔸	Markup appears, but there's no styling like on the WordPress page. This was applied to the element #meetup_oembed.
Mixcloud Embed	✅
Polldaddy Embed	✅	Support fixed in #829. Only link is shown.
Reddit Embed	🔸	Some markup appears, but without styling
ReverbNation Embed	✅
Screencast Embed	🔸	Displays "Unable to display content. Adobe Flash is required," even with the domain added to Chrome's Flash "Allow" list.
Scribd Embed	✅
SlideShare Embed	✅
SmugMug Embed	✅
Someecards Embed	✅
SoundCloud Embed	✅	Support fixed in #829.
Speaker Deck Embed	✅
Spotify Embed	✅
Ted Embed	✅
Tumblr Embed	🔸	Only shows the link.
Twitter Embed	✅
VideoPress Embed	✅
Vimeo Embed	✅
WordPress Plugin Directory Embed	🔸	Appears mainly as expected, but with slightly different styling and an extra link
WordPress.tv Embed	✅
YouTube Embed	✅

[kienstra]

Supported Embed Types

Hi @ThierryA,
Your comment above shows whether most of WordPress's supported embeds render properly in AMP.

There are some embeds that don't even render in a standard WordPress page, like Scribd and Photobucket.

And @westonruter's pull request has the wp-cli script to create a test page with those embeds and media types.

[westonruter]

@kienstra It looks like some of the oEmbed providers aren't all listed yet. I'm looking at the list here: https://github.com/WordPress/wordpress-develop/blob/c6326694380722ccbdd78e21a2bd0d079383291c/src/wp-includes/class-oembed.php#L54-L119

I don't see animoto, speakerdeck, or amazon for example. Could you please make sure every oEmbed is included in the list and in the test data?

[kienstra]

Will Add Missing oEmbed URLS

Hi @westonruter,
Sure, I'll add the missing oEmbed URLs tomorrow (Thursday) if that's alright.

[westonruter]

Deployed changes to the testbed site and created test page with embeds:

Non-AMP: http://amp-xwp-testbed.pantheonsite.io/amp-test-embeds/
AMP: http://amp-xwp-testbed.pantheonsite.io/amp-test-embeds/?amp

[ahmadawais]

@ThierryA it would be great to have that AMP Support table there on the README.md or in a AMP-SUPPORT.md what do you think?

Also excited about this enhancement.

[ThierryA]

Thanks for your suggestion @ahmadawais, a wiki page would probably be the best place for that. The readme is already pretty long and we plan to do more "Vanilla WordPress Support" discovery such as widgets etc.

[westonruter]

The wiki is easier to update on an ongoing basis as well.

[ahmadawais]

Right about that. Works for me.

[kienstra]

Wiki Page

Hi @ahmadawais and @westonruter,
Here's the wiki page that shows widget and embed support.