Add support for amp-soundcloud #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjangda
reviewed
Feb 19, 2017
| $parsed_url = parse_url( $url ); | ||
| parse_str( $parsed_url['path'], $path ); | ||
| $tok = explode("/", $parsed_url['path']); | ||
| $tok = explode("_", $tok[2]); |
There was a problem hiding this comment.
Do we need the _ explode here?
There was a problem hiding this comment.
My bad; not needed. Fixed.
amedina
force-pushed
the
amedina/amp-soundcloud
branch
from
038bd12 to
f827814
Compare
|
@amedina as part of #806 I found the implementation here to not be complete. In particular, an oEmbed for SoundCloud looks like: https://soundcloud.com/jack-villano-villano/mozart-requiem-in-d-minor Not like: https://api.soundcloud.com/tracks/89299804 Additionally, I found the So I've amended the PR #829 to fix up the SoundCloud handling: 0b729b1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting this PR started for review and discussion.