Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic of github_api to autodetect host #127

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Fix logic of github_api to autodetect host #127

merged 2 commits into from
Sep 19, 2024

Conversation

AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Sep 19, 2024 •
edited
Loading

Fixes #125

  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@AliSoftware AliSoftware requested review from wzieba and a team September 19, 2024 12:33
@AliSoftware AliSoftware added the bug Something isn't working label Sep 19, 2024
@AliSoftware AliSoftware self-assigned this Sep 19, 2024
@AliSoftware AliSoftware mentioned this pull request Sep 19, 2024
Closed
wzieba
wzieba approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@wzieba wzieba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) I'll follow up with sarif script update then

@AliSoftware AliSoftware merged commit c4e9a60 into trunk Sep 19, 2024
15 of 16 checks passed
@AliSoftware AliSoftware deleted the fix/github_api branch September 19, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzieba wzieba wzieba approved these changes

Assignees

@AliSoftware AliSoftware

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix github_api helper to use BUILDKITE_REPO
2 participants
@AliSoftware @wzieba