Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github_api helper to use BUILDKITE_REPO #125

Closed
wzieba opened this issue Sep 19, 2024 · 1 comment · Fixed by #127
Closed

Fix github_api helper to use BUILDKITE_REPO #125

wzieba opened this issue Sep 19, 2024 · 1 comment · Fixed by #127
Labels
bug Something isn't working

Comments

@wzieba
Copy link
Member

wzieba commented Sep 19, 2024

@AliSoftware
Copy link
Contributor

AliSoftware commented Sep 19, 2024

@wzieba Ah, I missed this, I already made a PR to fix it in #127 😅

We could recycle this issue to instead say "adopt github_api helper in upload_sarif_to_github implementation instead though, as #127 didn't cover that, and I'm guessing you probably only want to look at that once you've confirmed your initial issue on trunk branch of client repos? 🤷
Or if you update upload_sarif_to_github right away we can keep this issue closed and done; whatever you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants