Use BUILDKITE_REPO to retrieve repo owner and name #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, the upload will also work on commits not associated with a PR
wzieba
commented
Sep 19, 2024
AliSoftware
approved these changes
Sep 19, 2024
Comment on lines
-67
to
+71
| https://api.github.com/repos/"$owner"/"$repo"/code-scanning/sarifs | ||
| https://api.github.com/repos/"$slug"/code-scanning/sarifs |
There was a problem hiding this comment.
I was going to suggest to use our github_api helper from this plugin while at it… but then looking at its code I just realized that has the similar issue of relying on BUILDKITE_PULL_REQUEST_REPO instead of BUILDKITE_REPO—and besides, the awk program it uses to attempt to extract the host if not provided is incorrect, as there's no field 4… so we'll need to fix that helper in a separate PR I guess, only at which point one could consider using it in your sarif helper implementation 🙃
There was a problem hiding this comment.
Thanks for checking this! I've added a task so we won't forget: #125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the upload will also work on commits not associated with a PR
Test:
CHANGELOG.mdif necessary.