Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIP: Enable co-authors plus filter that disabled the querying by post_author on VIP Go #653

Open
wants to merge 392 commits into
base: develop
Choose a base branch
from

Conversation

shantanu2704
Copy link
Contributor

This speeds up the SQL query. This filter has been enabled on WordPress.com VIP. This filter is active on WordPress.com VIP but not on VIP Go.

We'd need to run the backfill CLI before this can be merged in.

Rebecca Hum and others added 30 commits September 8, 2017 13:18
…_list_authors

remove duplicates from linked accounts on coauthors_wp_list_authors()
…uthors

coauthors_wp_list_authors() has option to list only guest authors now
Remove associated guest user when mapped user id deleted.
user_login spaces problem when using add_coauthors
- Use simple tax queries for CAP to improve performance
- Detail of filter to add to theme
- Adding CLI command to run
Adding details of filter for slow performance
Since we made CAP consistent with core in it's handling of author archives where there are no posts (see Automattic#425) we no longer expect there to be a 404 response on the author archive for a guest author.
…table

Guest Author Counts are more accurate
rebeccahum and others added 21 commits November 29, 2018 07:52
This is a pretty big hack :) It would be better to remove the inputs completely rather than hiding them (via javascript or hooking directly into Gutenberg) but this is a good start.
…mpat

Use CSS to hide the Block Editor's Author label + select
Revert "BUGFIX regular expression in posts_where_filter()"
SQL Error from Regex in WHERE Clause
This is a pretty big hack :) It would be better to remove the inputs completely rather than hiding them (via javascript or hooking directly into Gutenberg) but this is a good start.
Merge 3.3.1 release for Gutenberg compatibility to master
…l-filter-get_coauthors-1

# Conflicts:
#	template-tags.php
…_coauthors-1

Add filter to get_coauthors
…_author on VIP Go

This speeds up the SQL query. This filter has been enabled on WordPress.com VIP. This filter is active on WordPress.com VIP
but not on VIP Go.
@GaryJones
Copy link
Contributor

@shantanu2704 Is this still needed for VIP?

@shantanu2704
Copy link
Contributor Author

I don't know, @GaryJones :(
I'm looking back at VIP Intern Shantanu in disappointment for not including any further details.
Thanks to GitHub, here's some more context around why we considered adding this filter.

@GaryJones
Copy link
Contributor

Adding to a future milestone to investigate later on. @shantanu2704 Do you fancy checking to see if the query by post_author is coming up as slow / needed any more?

@GaryJones GaryJones changed the base branch from main to develop August 25, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.