Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0 posts for Guest Author different than 0 posts for WP User #425

Closed
trepmal opened this issue Jun 2, 2017 · 2 comments
Closed

0 posts for Guest Author different than 0 posts for WP User #425

trepmal opened this issue Jun 2, 2017 · 2 comments
Milestone

Comments

@trepmal
Copy link
Contributor

trepmal commented Jun 2, 2017

Related #201, #409

Setup

I have created 2 users:

  • lazy-author: A standard WP User (role: author) with 0 posts
  • lazy-guest: A Guest Author with 0 posts

Author archive for the first - http://local.wordpress.local/author/lazy-author/ - returns a 200, with "no posts found"

Author archive for the second - http://local.wordpress.local/author/lazy-guest/ - returns a 404, with an "oops" message

I'm not sure we should return a 404, as this doesn't match core behavior. I think we might just be dealing with cruft left over after copy-pasta rotted a bit.

@rebeccahum
Copy link
Contributor

+1 to this for consistency with core. It would also cause less confusion for those building custom author templates with this plugin.

@philipjohn
Copy link
Contributor

Agreed, let's make this consistent with core.

@trepmal trepmal closed this as completed in c066be2 Jul 6, 2017
@philipjohn philipjohn added this to the 3.3 milestone Oct 13, 2017
philipjohn added a commit that referenced this issue Oct 22, 2017
Since we made CAP consistent with core in it's handling of author archives where there are no posts (see #425) we no longer expect there to be a 404 response on the author archive for a guest author.
rebeccahum pushed a commit that referenced this issue Mar 26, 2019
Since we made CAP consistent with core in it's handling of author archives where there are no posts (see #425) we no longer expect there to be a 404 response on the author archive for a guest author.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants